From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1521) id E2DC5385842C; Tue, 2 Jan 2024 04:36:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2DC5385842C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1704170175; bh=T/gIGJTgDzQ3W24z3qwQkN2NR8PHYnM/cNXYzQ/bsIU=; h=From:To:Subject:Date:From; b=e+ifjczB6lHU4XkzfRVKqL0usYw//FGfmBEcMF7mOVJbIaiYUtcYXxLG4B7HzPC+6 px8AeJ6ioXGGliOqgzLvzpIDyuFl72UQeXeo01B+tde3xGaMbp1hrT4Dzs0tQOgK3y owz0lCs3Q+4zAxjV/0oNritUUb8f5/o6ieddd8Kg= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Frysinger To: newlib-cvs@sourceware.org Subject: [newlib-cygwin/users/vapier/wip] libgloss: msp430: delete outdated/wrong code X-Act-Checkin: newlib-cygwin X-Git-Author: Mike Frysinger X-Git-Refname: refs/heads/users/vapier/wip X-Git-Oldrev: 6f6d67a012b004f9d1fdcf74da33dcd9aea42c2b X-Git-Newrev: 025679996d1fb3bc985f5e22c6b111b5ef2093fd Message-Id: <20240102043615.E2DC5385842C@sourceware.org> Date: Tue, 2 Jan 2024 04:36:15 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D025679996d1= fb3bc985f5e22c6b111b5ef2093fd commit 025679996d1fb3bc985f5e22c6b111b5ef2093fd Author: Mike Frysinger Date: Tue Dec 26 21:46:59 2023 -0500 libgloss: msp430: delete outdated/wrong code =20 The #if 0 & comment imply this code doesn't exist and is never used, except there's another #if Lrun_fini_array section below which *does* define this function, which makes this code comment confusing. This seems to be a hold over of the cleanup of the minrt code in the old commit 884b05b54e4595433c85f8ca9820e88b4c723e38 ("MSP430: Remove .init/.fini sections"). Diff: --- libgloss/msp430/crt0.S | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/libgloss/msp430/crt0.S b/libgloss/msp430/crt0.S index 88876cd48..c0b258f50 100644 --- a/libgloss/msp430/crt0.S +++ b/libgloss/msp430/crt0.S @@ -195,20 +195,6 @@ START_CRT_FUNC 0600 run_init_array END_CRT_FUNC run_init_array #endif /* Lrun_init_array */ =20 -;; FIXME: There are currently no program termination routines executed for -;; msp430. -#if 0 -#if Lrun_fini_array -;; Ensure global C++ destructors in .fini_array are called on exit -;; by registering __crt0_run_fini_array with atexit. -START_CRT_FUNC 0700 register_fini_array - - mov_ #__crt0_run_fini_array, R12 - call_ #atexit - -END_CRT_FUNC register_fini_array -#endif /* Lrun_fini_array */ -#endif /* 0 */ =20 #if Lmain ;; This function is always included and calls main().