public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Frysinger <vapier@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin/users/vapier/wip] libgloss: msp430: delete custom .S.o rule
Date: Tue,  2 Jan 2024 04:36:34 +0000 (GMT)	[thread overview]
Message-ID: <20240102043635.003973858404@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=b24d6278babf6f65aa933166e45835cc3f466c72

commit b24d6278babf6f65aa933166e45835cc3f466c72
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Tue Dec 26 22:17:22 2023 -0500

    libgloss: msp430: delete custom .S.o rule
    
    This was added to specify -Wa,-gdwarf2 when compiling the assembly
    files.  Considering the size of these .S files, it seems unnecessary
    overkill and complicates the build system.  All but one of these
    compile down to 6 or fewer lines, and those hardly need extra debug
    for anyone who is poking msp430 assembly.  The 1 file that is larger
    than that (crt_move_highdata.S) is still <15 insns.
    
    This will also simplify merging it into the top-level Makefile.

Diff:
---
 libgloss/msp430/Makefile.in | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libgloss/msp430/Makefile.in b/libgloss/msp430/Makefile.in
index ccf94dc16..62c8a280b 100644
--- a/libgloss/msp430/Makefile.in
+++ b/libgloss/msp430/Makefile.in
@@ -96,10 +96,6 @@ CRT_OBJS = \
 
 all: $(CRT) $(SIM_BSP) $(LIB_NOSYS) $(LIB_CRT) copy_scripts_to_objdir
 
-# Override .S.o rule to pass assembler debugging flags
-.S.o:
-	$(CC) -Wa,-gdwarf2 -Wa,-I$(srcdir) $(CFLAGS_FOR_TARGET) $(INCLUDES) $(CFLAGS) -c $<
-
 $(SIM_BSP): $(SIM_OBJS)
 	$(AR) $(ARFLAGS) $@ $?
 	$(RANLIB) $@

                 reply	other threads:[~2024-01-02  4:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240102043635.003973858404@sourceware.org \
    --to=vapier@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).