public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin/main] _fputwc_r: actually return result of __fputwc
Date: Fri, 19 Jan 2024 10:52:05 +0000 (GMT)	[thread overview]
Message-ID: <20240119105205.C76743858006@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=d13d9220bf47f7e91b02c5c8e214780bda840606

commit d13d9220bf47f7e91b02c5c8e214780bda840606
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Fri Jan 19 11:13:39 2024 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Fri Jan 19 11:13:39 2024 +0100

    _fputwc_r: actually return result of __fputwc
    
    Compiling with -Wall uncovered a bug in _fputwc_r introduced in
    commit 09119463a1445 ("stdio: split byte- and wide-char-oriented
    low-level output functions").  The underlying function __fputwc
    has been accidentally called without fetching its return value.
    So the return value of _fputwc_r (and thus fputwc) was undefined.
    
    Fixes: 09119463a1445 ("stdio: split byte- and wide-char-oriented low-level output functions"
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 newlib/libc/stdio/fputwc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libc/stdio/fputwc.c b/newlib/libc/stdio/fputwc.c
index 8430446dea40..12a6170bbc55 100644
--- a/newlib/libc/stdio/fputwc.c
+++ b/newlib/libc/stdio/fputwc.c
@@ -169,7 +169,7 @@ _fputwc_r (struct _reent *ptr,
   wint_t r;
 
   _newlib_flockfile_start (fp);
-  __fputwc(ptr, wc, fp);
+  r = __fputwc(ptr, wc, fp);
   _newlib_flockfile_end (fp);
   return r;
 }

                 reply	other threads:[~2024-01-19 10:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240119105205.C76743858006@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).