public inbox for newlib-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: newlib-cvs@sourceware.org Subject: [newlib-cygwin/main] memccpy: fix pointer assignment Date: Fri, 19 Jan 2024 10:52:15 +0000 (GMT) [thread overview] Message-ID: <20240119105216.B7A2D38582AE@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=422c4f0451ccaff9aa38ee86d5d860f41c7bf9ef commit 422c4f0451ccaff9aa38ee86d5d860f41c7bf9ef Author: Corinna Vinschen <corinna@vinschen.de> AuthorDate: Fri Jan 19 11:28:11 2024 +0100 Commit: Corinna Vinschen <corinna@vinschen.de> CommitDate: Fri Jan 19 11:51:01 2024 +0100 memccpy: fix pointer assignment The local vars dst and src are unsigned pointers, but two assignments cast their value to signed explicitely. This results in the warning "pointer targets in assignment from ‘char *’ to ‘unsigned char *’ differ in signedness [-Wpointer-sign]" in case of -Wall. Fix the cast. Fixes: d254189b38bb ("2002-07-23 Jeff Johnston <jjohnstn@redhat.com>") Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- newlib/libc/string/memccpy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/newlib/libc/string/memccpy.c b/newlib/libc/string/memccpy.c index 6757cb34cb2d..d6b2f8beabe1 100644 --- a/newlib/libc/string/memccpy.c +++ b/newlib/libc/string/memccpy.c @@ -118,8 +118,8 @@ memccpy (void *__restrict dst0, } /* Pick up any residual with a byte copier. */ - dst = (char*)aligned_dst; - src = (char*)aligned_src; + dst = (unsigned char*)aligned_dst; + src = (unsigned char*)aligned_src; } while (len0--)
reply other threads:[~2024-01-19 10:52 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240119105216.B7A2D38582AE@sourceware.org \ --to=corinna@sourceware.org \ --cc=newlib-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).