From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1521) id C198D3858422; Sat, 20 Jan 2024 01:26:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C198D3858422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1705713986; bh=1gp9vLnIa7E0fWWR6+y7LgeIirz9pAdhcDAHFaSS/AI=; h=From:To:Subject:Date:From; b=wqf2R3YwvuQHVYOZmu8E4UH8hiJacr5Q4/H8BUd1Llyflu+77+YLmDNtkP5MZH9hc ziu69Un+5aP0uXF0Tzuf4A2tql6bdZVRFpnyJfct7QBJ71aQ8YUJa22g1oTEQ6a+EP 0BTBRvXUM3+61p6263awTI50sfN3EJvi3ALPxGUo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Frysinger To: newlib-cvs@sourceware.org Subject: [newlib-cygwin/main] libgloss: msp430: delete outdated/wrong code X-Act-Checkin: newlib-cygwin X-Git-Author: Mike Frysinger X-Git-Refname: refs/heads/main X-Git-Oldrev: 58da25856169ca9e64105079f00f4adaefeca35b X-Git-Newrev: 0ed55d03b7e1083cd721a52876f021b211f3e24a Message-Id: <20240120012626.C198D3858422@sourceware.org> Date: Sat, 20 Jan 2024 01:26:26 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D0ed55d03b7e= 1083cd721a52876f021b211f3e24a commit 0ed55d03b7e1083cd721a52876f021b211f3e24a Author: Mike Frysinger Date: Tue Dec 26 21:46:59 2023 -0500 libgloss: msp430: delete outdated/wrong code =20 The #if 0 & comment imply this code doesn't exist and is never used, except there's another #if Lrun_fini_array section below which *does* define this function, which makes this code comment confusing. This seems to be a hold over of the cleanup of the minrt code in the old commit 884b05b54e4595433c85f8ca9820e88b4c723e38 ("MSP430: Remove .init/.fini sections"). Diff: --- libgloss/msp430/crt0.S | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/libgloss/msp430/crt0.S b/libgloss/msp430/crt0.S index 88876cd48..c0b258f50 100644 --- a/libgloss/msp430/crt0.S +++ b/libgloss/msp430/crt0.S @@ -195,20 +195,6 @@ START_CRT_FUNC 0600 run_init_array END_CRT_FUNC run_init_array #endif /* Lrun_init_array */ =20 -;; FIXME: There are currently no program termination routines executed for -;; msp430. -#if 0 -#if Lrun_fini_array -;; Ensure global C++ destructors in .fini_array are called on exit -;; by registering __crt0_run_fini_array with atexit. -START_CRT_FUNC 0700 register_fini_array - - mov_ #__crt0_run_fini_array, R12 - call_ #atexit - -END_CRT_FUNC register_fini_array -#endif /* Lrun_fini_array */ -#endif /* 0 */ =20 #if Lmain ;; This function is always included and calls main().