public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin/main] libgloss: riscv: Fix envp parameter for main
Date: Fri, 12 Apr 2024 09:44:51 +0000 (GMT)	[thread overview]
Message-ID: <20240412094451.CC0F73858417@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=730703bdb8e1ae671517efaa0b9e273eef52d724

commit 730703bdb8e1ae671517efaa0b9e273eef52d724
Author:     Bernd Edlinger <bernd@edlinger-online.de>
AuthorDate: Thu Apr 11 14:57:11 2024 +0200
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Fri Apr 12 11:44:07 2024 +0200

    libgloss: riscv: Fix envp parameter for main
    
    The envp paramter is currently NULL when crt0.S calls main.
    With this patch the envp parameter should now be set correctly.
    Tested with riscv32 and riscv64: both gdb/sim and qemu do work.

Diff:
---
 libgloss/riscv/crt0.S | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libgloss/riscv/crt0.S b/libgloss/riscv/crt0.S
index f1c5419a5eb4..54443e4129dc 100644
--- a/libgloss/riscv/crt0.S
+++ b/libgloss/riscv/crt0.S
@@ -61,7 +61,9 @@ _start:
 
   lw      a0, 0(sp)                  # a0 = argc
   addi    a1, sp, __SIZEOF_POINTER__ # a1 = argv
-  li      a2, 0                      # a2 = envp = NULL
+  slli    a2, a0, 1 + __SIZEOF_POINTER__ >> 2
+  addi    a2, a2, __SIZEOF_POINTER__
+  add     a2, a2, a1                 # a2 = envp
   call    main
   tail    exit
   .size  _start, .-_start

                 reply	other threads:[~2024-04-12  9:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240412094451.CC0F73858417@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).