From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id 244543857831 for ; Wed, 4 May 2022 13:38:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 244543857831 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy01.your-server.de ([78.46.139.224]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nmFDI-0000oy-0s for newlib@sourceware.org; Wed, 04 May 2022 15:38:44 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmFDI-00075F-5T for newlib@sourceware.org; Wed, 04 May 2022 15:38:44 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id D46EC480170 for ; Wed, 4 May 2022 15:38:43 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id isuYt7fELyP0 for ; Wed, 4 May 2022 15:38:43 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 8CA9E480195 for ; Wed, 4 May 2022 15:38:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id aJEQDhKXFYnB for ; Wed, 4 May 2022 15:38:43 +0200 (CEST) Received: from [10.10.171.14] (unknown [10.10.171.14]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 57B9D480170 for ; Wed, 4 May 2022 15:38:43 +0200 (CEST) Message-ID: <00134eba-8dfe-888e-104c-c0c374b538e3@embedded-brains.de> Date: Wed, 4 May 2022 15:38:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] Remove use of _global_impure_ptr Content-Language: en-US To: newlib@sourceware.org References: <20220503134043.122345-1-sebastian.huber@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.5/26531/Wed May 4 10:05:36 2022) X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 13:38:47 -0000 On 04/05/2022 15:34, Corinna Vinschen wrote: > On May 3 15:40, Sebastian Huber wrote: >> Remove the pointer indrection through the read-only _global_impure_ptr= and >> directly use a globally visible _impure_data object of type struct ree= nt. This >> enables the static initialization of global data structures in a follo= w up >> patch. In addition, we get rid of a machine-specific file. > the patch looks good. I just wonder if we really need the > impure-compat.c file. Backward-compat is no problem for embedded stuff= , > and Cygwin doesn't expose _global_impure_ptr to user space either. >=20 > If there's no other compelling reason, you can just drop it and push > the rest. Yes, _GLOBAL_REENT is only used by Newlib modules and not in public=20 macros/inline functions. If applications don't use this internal item,=20 then we don't need the impure-compat.c. I will check in the patch without the impure-compat.c. If needed we can=20 add it later. --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/