From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16442 invoked by alias); 21 Jun 2017 06:46:09 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 16429 invoked by uid 89); 21 Jun 2017 06:46:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.4 required=5.0 tests=AWL,BAYES_00,FOREIGN_BODY,RCVD_IN_DNSWL_NONE,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=no version=3.3.2 spammy=Fax, Phone, phone X-HELO: dedi548.your-server.de Received: from dedi548.your-server.de (HELO dedi548.your-server.de) (85.10.215.148) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 06:46:07 +0000 Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1dNZOv-0007Mo-0d; Wed, 21 Jun 2017 08:46:05 +0200 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dNZOu-0005Gh-Po; Wed, 21 Jun 2017 08:46:04 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 7ABAD2A004F; Wed, 21 Jun 2017 08:46:21 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id LUX2nWuy-a-8; Wed, 21 Jun 2017 08:46:21 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 16E6C2A160A; Wed, 21 Jun 2017 08:46:21 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mHu7dJPeG127; Wed, 21 Jun 2017 08:46:21 +0200 (CEST) Received: from [192.168.96.129] (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTPSA id ECE102A004F; Wed, 21 Jun 2017 08:46:20 +0200 (CEST) Subject: Re: Importing cacoshl.c and its dependent methos, To: aditya upadhyay , newlib@sourceware.org References: From: Sebastian Huber Message-ID: <0205aa55-7b80-245d-0af6-4fe67c15429f@embedded-brains.de> Date: Wed, 21 Jun 2017 06:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00444.txt.bz2 On 21/06/17 04:24, aditya upadhyay wrote: > Hello Developers, > In cacoshl.c, There is a dependency between cacoshl.c and csqrtl.c. > In ported csqrtl.c from NetBSD, stdbool.h is there, But i saw there > is no stdbool.h. > > So for bool data type, I have used enum. Is it a right way or not. > please suggest or do i have to use stdbool.h from gcc library ? is currently not used by Newlib. I am not sure if we should=20 add this dependency if its only needed by csqrtl.c (in overall NetBSD=20 libm) and not visible to the user. I would replace the #include with #ifndef __cplusplus typedef enum { false, true } bool; #endif and keep the rest of the code unchanged. --=20 Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.huber@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG.