From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) by sourceware.org (Postfix) with ESMTPS id 6D0FF385737E for ; Thu, 12 May 2022 14:48:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6D0FF385737E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=SystematicSw.ab.ca Authentication-Results: sourceware.org; spf=none smtp.mailfrom=systematicsw.ab.ca Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id p3uxnbQMlwtwGpA6tntDIq; Thu, 12 May 2022 14:48:11 +0000 Received: from [10.0.0.5] ([184.64.124.72]) by cmsmtp with ESMTP id pA6unaF4RsF60pA6un7xQI; Thu, 12 May 2022 14:48:13 +0000 X-Authority-Analysis: v=2.4 cv=Z8n/oVdA c=1 sm=1 tr=0 ts=627d1e2d a=oHm12aVswOWz6TMtn9zYKg==:117 a=oHm12aVswOWz6TMtn9zYKg==:17 a=IkcTkHD0fZMA:10 a=94nOnFI1EgyDtX4ev68A:9 a=QEXdDO2ut3YA:10 Message-ID: <0856b9dc-ef50-234e-9327-32eff276dda4@SystematicSw.ab.ca> Date: Thu, 12 May 2022 08:48:12 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Reply-To: newlib@sourceware.org Subject: Re: [PATCH] Cygwin: signal.cc: Include Content-Language: en-CA To: newlib@sourceware.org References: <20220512064332.23298-1-sebastian.huber@embedded-brains.de> From: Brian Inglis Organization: Systematic Software In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfL4FBt9F0nlc69GVJxWX9TM7pyWQY/6bMbyfIpcPp7ytWaEviVmsz8cy1whg+bo1U349KLd2BLyn83JEQ5S9IEGqASrvKyInooOPIi3Ief78e9KNDycl GCgyOsyGW+e3P3ErK0bJ8pABuI1UzGhp/OrzS9FrD9+HaEp8oAAxkm59EQHw6ZbJ99vchADafdmKGFb4Xmp2UZgMb79+eGxRui8= X-Spam-Status: No, score=-1165.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 14:48:16 -0000 On 2022-05-12 02:46, Corinna Vinschen wrote: > On May 12 10:22, Sebastian Huber wrote: >> On 12/05/2022 10:14, Corinna Vinschen wrote: >>>> sleep (unsigned int seconds) >>>> { >>>> struct timespec req, rem; >>>> @@ -174,7 +175,7 @@ sleep (unsigned int seconds) >>>> return 0; >>>> } >>>> -extern "C" unsigned int >>>> +int >>>> usleep (useconds_t useconds) >>> Good catch, otherwise, thank you! I'd prefer if you push just the >>> type change and keep the extern "C" as a marker for exported functions. >> >> Ok, what about the unistd.h include? > > Let's keep it. It might help to uncover other issues in future. Shouldn't these Cygwin winsup patches be posted separately to cygwin-patches rather than newlib, once any newlib patches they depend on have been accepted. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in binary units and prefixes, physical quantities in SI.]