From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id D285B3857C42 for ; Fri, 14 Aug 2020 04:52:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D285B3857C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sebastian.huber@embedded-brains.de Received: from sslproxy05.your-server.de ([78.46.172.2]) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1k6Rh8-0001rp-9Z; Fri, 14 Aug 2020 06:51:58 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1k6Rh8-000NXn-60; Fri, 14 Aug 2020 06:51:58 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 5B1AD2A1610; Fri, 14 Aug 2020 06:52:22 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6mExNSqzCMy7; Fri, 14 Aug 2020 06:52:22 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 17C7F2A165B; Fri, 14 Aug 2020 06:52:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uv5saF1S4jII; Fri, 14 Aug 2020 06:52:22 +0200 (CEST) Received: from shuber-nb-linux.eb.localhost (unknown [10.10.171.22]) by mail.embedded-brains.de (Postfix) with ESMTPSA id D37512A1610; Fri, 14 Aug 2020 06:52:21 +0200 (CEST) Subject: Re: [PATCH] Removed Soft float from MIPS To: joel@rtems.org, Newlib , Eshan dhawan , joel@rtems.com Cc: Corinna Vinschen References: <20200812213535.25430-1-eshandhawan51@gmail.com> <20200813081945.GW53219@calimero.vinschen.de> From: Sebastian Huber Message-ID: <0d8f47a6-00a2-9a85-5b0e-6f607cd2c685@embedded-brains.de> Date: Fri, 14 Aug 2020 06:51:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.102.4/25901/Thu Aug 13 09:01:24 2020) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Aug 2020 04:52:03 -0000 On 13/08/2020 15:10, Joel Sherrill wrote: > On Thu, Aug 13, 2020 at 3:19 AM Corinna Vinschen via Newlib < > newlib@sourceware.org> wrote: > >> On Aug 13 03:05, Eshan dhawan via Newlib wrote: >>> This Patch removes Soft Float code from MIPS. >>> Instead It adds the soft float code from RISCV >> Why, and why is that the right thing to do? >> > The code came from FreeBSD and assumes the FreeBSD softfp > implementation not the one with GCC. That was an overlooked and > fixed in the other fenv code already. There is now a lot of copy and paste involved in the fenv support. I think the soft float support should be unified with a shared implementation. This can be later enhanced with support for the GCC soft float implementation.