From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97228 invoked by alias); 10 Apr 2019 14:55:37 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 97047 invoked by uid 89); 10 Apr 2019 14:55:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=delayed X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Apr 2019 14:55:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 63C68374; Wed, 10 Apr 2019 07:55:34 -0700 (PDT) Received: from e120077-lin.cambridge.arm.com (e120077-lin.cambridge.arm.com [10.2.206.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 51FAD3F557; Wed, 10 Apr 2019 07:55:33 -0700 (PDT) Subject: Re: [Arm] SP and SL initialization refactored To: Alexander Fedotov , Nick Clifton , Tamar Christina , Newlib , nd References: <20190410142353.GI4248@calimero.vinschen.de> From: "Richard Earnshaw (lists)" Openpgp: preference=signencrypt Message-ID: <0e86fe93-50b9-82e2-c57d-8ef731080d2e@arm.com> Date: Wed, 10 Apr 2019 14:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190410142353.GI4248@calimero.vinschen.de> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2019/txt/msg00154.txt.bz2 On 10/04/2019 15:23, Corinna Vinschen wrote: > Hi Richard, > > On Apr 10 13:26, Richard Earnshaw (lists) wrote: >> On 19/03/2019 13:54, Alexander Fedotov wrote: >>> Hi all >>> >>> In continue of threads >>> https://sourceware.org/ml/newlib/2019/msg00117.html and >>> https://sourceware.org/ml/newlib/2019/msg00102.html >>> >>> I have reworked stack pointer initialization and stack limit as well. >>> General idea behind of all these changes is to provide hook for >>> flexibility (including semihosting when debug tap is used) and improve >>> readability of existing crt0 code. >>> And now code makes SP initialization in Thumb mode :) >>> >>> Any comments are very appreciated. >>> >>> Alex >>> >> >> Apologies once again for the delayed review. >> >> A small plea: when posting patches, please can you ensure that your >> attachments are text/patch, or something similar, so that replies will >> include the contents (and I can view them directly in the email rather >> than having to mess about extracting the attachment). > > Ideally the patches are inline patches sent with `git send-email' or > equivalent. I added some wording in terms of how to provide patches to > https://sourceware.org/newlib/ lately. Do you have a suggestion for > improving this? > > > Thanks, > Corinna > Not really; When I use git format-patch with --attach I get text/x-patch as the MIME type, which is fine. Problems only start if users have poorly configured mail client that attach as octet-stream or other binary types. Then mail clients can't display the attachment inline as they don't know the format is really displayable. R.