From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) by sourceware.org (Postfix) with ESMTPS id 542E4385802F for ; Thu, 23 Feb 2023 15:12:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 542E4385802F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=Shaw.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=shaw.ca Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTP id V41kpYyp6uZMSVDH8puiGA; Thu, 23 Feb 2023 15:12:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=shaw.ca; s=s20180605; t=1677165170; bh=n+j5HBJv0yG5f5J9vv5ZWngDEnC/b9rHZWXHJWJuhMQ=; h=Date:From:Subject:Reply-To:To:References:In-Reply-To; b=RBBBy5mKObw2c5g7RqFK+1GBuR/QZDLuIt6cFH2d1Egkv/0KusF+D5nS5y1j9zOTs q3njqTLQFM1OjJPZUXq65JlCDg8zdlrAt6c2dUS0JvBv/JVDnDxi6iQK/iGWON9oTa SftJ2KUOPPEl0KA7cs4/lSh6HLpTzRIWyd+iRbtVifiSMvemrGP0zsxvwlwg+PCGHt YPrtc/BoprYizIg6pVv3vagImdC2XAo549WN4EvWKxlUuDkek6X2adgdOyDyPgLN/t mG2bkQbpRCfikbBPhKLJG8eOGYHi9mTc8DnmZBQKLStdgpPzZxvNriUeGctF0emy4O lUBrGjCDLvvfA== Received: from [10.0.0.5] ([184.64.102.149]) by cmsmtp with ESMTP id VDH8pkTV3yAOeVDH8pt9rc; Thu, 23 Feb 2023 15:12:50 +0000 X-Authority-Analysis: v=2.4 cv=e5oV9Il/ c=1 sm=1 tr=0 ts=63f78272 a=DxHlV3/gbUaP7LOF0QAmaA==:117 a=DxHlV3/gbUaP7LOF0QAmaA==:17 a=IkcTkHD0fZMA:10 a=mDV3o1hIAAAA:8 a=p-pPQmOa3Xwo7jRFKD4A:9 a=QEXdDO2ut3YA:10 a=AP3JQZ_qGYIA:10 a=_FVE-zBwftR9WsbkzFJk:22 Message-ID: <115a1e69-4265-e1cd-afca-db6f09196ee6@Shaw.ca> Date: Thu, 23 Feb 2023 08:12:49 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Brian Inglis Subject: Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues Reply-To: newlib@sourceware.org To: newlib@sourceware.org References: <20230217204902.3735-1-Brian.Inglis@Shaw.ca> <381ec8a8-1809-0eba-6321-f9cb32143995@dronecode.org.uk> <4c52eb49-e114-53e6-b30b-48bbfb6ba9bc@Shaw.ca> <8ec9372f-2bc9-919d-cd04-3ef3d71020d9@dronecode.org.uk> Content-Language: en-CA Organization: Inglis In-Reply-To: <8ec9372f-2bc9-919d-cd04-3ef3d71020d9@dronecode.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfDFRdDZ8nBRHSN9F4F6VBwk7cNop+LJkt48VLVnDSgAJunVZ5R8r3zmlrbOoLM/B8QEWzHWN2HZPTcE0i66k//ics9jNDpWxWxLu89TwMD5X6lDfsJWe Oiuotu+XTJz0L8iHe0eXIghcNb5Rm/vkXu6NuAZcutc2P6UnjLA7wZ2sV7tbbcbC82Lj3yji/LDR2w== X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-02-22 13:10, Jon Turney wrote: > On 20/02/2023 23:20, Brian Inglis wrote: >> On 2023-02-20 15:03, Jon Turney wrote: >>> On 20/02/2023 20:25, Brian Inglis wrote: >>>> On 2023-02-20 02:45, Corinna Vinschen wrote: >>>>> Hi Brian, >>>>> >>>>> On Feb 17 13:49, Brian Inglis wrote: >>>>>> Brian Inglis (2): >>>>>>    newlib/libc/time/strftime.c: split table of conversion >>>>>>      specifiers to fix man, tbl, groff multi-page table issues >>>>>>    newlib/libc/Makefile.inc: sed fix strftime.3 table format >>>>>>      man, tbl, groff multi-page issues >>>>>> >>>>>>   newlib/libc/time/strftime.c | 3 ++- >>>>>>   newlib/libc/Makefile.inc    | 1 + >>>>>>   2 files changed, 3 insertions(+), 1 deletion(-) >>>>>> >>>>>> -- >>>>>> 2.39.0 >>>>> >>>>> Would you mind terribly to add more text to the commit messages? >>>>> explaining the problem, and its fix?  Just the subject line is quite >>>>> terse. >>>>> >>>>> For patch 1, why adding the split and what's the desired effect.  For >>>>> patch 2, what problem is the sed call fixing and what is the sed >>>>> expression doing? >>>> >>>> Thanks Corinna, You're right - will redo all v3. >>> >>> You should also describe why this must be fixed in this ad-hoc fasion, rather >>> than in the chew markup or makedocbook. >> >> I'll also ref the discussion with Branden, following comments from linux-man, >> the newlib man generation by docbook2man is incompatible with how man is >> incompatible with groff/tbl/grohtml: >> >> https://lists.gnu.org/archive/html/bug-groff/2023-02/msg00118.html > > Thanks, interesting reading. > >> via makedocbook python script which generates xml (attached), then >> docbook generates html, man pages, PDFs, texinfo, and the latter >> generate libc info.] > > This statement of yours is incorrect: > > The embedded documentation is processed ('chewed') by makedoc into texinfo, from > which html, info and PDFs are generated. > > The embedded documentation is also processed by makedocbook into docbook from > which manpages are generated. I realized I switched them due to similar names and possibly ToD or coffee lack. > Whatever you think of docbook as a pivot format for generating the manpages, > texinfo is much worse. Not my opinion - I don't mind GMLs or roffs - BTDT. > In theory you could use makedocbook as a starting point for directly outputting > groff manpages, if that's the only way to generate manpages of the quality desired. > >> I dug and could not find a good point to alter generation of tables > page >> size that may not adversely affect other [newlib] doc man page tables, where >> the problem occurs solely on that strftime.3 man page! > > These seem like generic problem in the docbook2man XSLT, which should be fixed > there. The problem is man -> tbl -> groff - see other reply. It may be fixed in groff v + 2. -- Take care. Thanks, Brian Inglis Calgary, Alberta, Canada La perfection est atteinte Perfection is achieved non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut -- Antoine de Saint-Exupéry