public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Subject: Re: [PATCH v3 1/2] Import strnstr.c from FreeBSD.
Date: Mon, 28 Aug 2017 14:59:00 -0000	[thread overview]
Message-ID: <1281337601.2137.1503931405363.JavaMail.zimbra@embedded-brains.de> (raw)
In-Reply-To: <20170828084021.GC18275@calimero.vinschen.de>


----- Corinna Vinschen <vinschen@redhat.com> schrieb:
> On Aug 25 19:56, Sebastian Huber wrote:
> > This caused a conflict with the iconv support.  See attached patch.
> 
> > From 754f598a0a0dbde072a5baa3d4c3374333326c76 Mon Sep 17 00:00:00 2001
> > From: Sebastian Huber <sebastian.huber@embedded-brains.de>
> > Date: Fri, 25 Aug 2017 19:48:42 +0200
> > Subject: [PATCH] Fix compile error due to new strnstr()
> > 
> > Remove local strnstr() implementation to fix compile error:
> > 
> > newlib/libc/iconv/lib/aliasesi.c:53:8: error: conflicting types for 'strnstr'
> >  _DEFUN(strnstr, (haystack, needle, length),
> >         ^
> > In file included from newlib/libc/iconv/lib/aliasesi.c:29:0:
> > newlib/libc/include/string.h:125:10:
> > note: previous declaration of 'strnstr' was here
> >  char    *strnstr(const char *, const char *, size_t) __pure;
> >           ^~~~~~~
> > 
> > Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> > ---
> >  newlib/libc/iconv/lib/aliasesi.c | 43 ----------------------------------------
> 
> Thanks for catching, please push.

 I am on holidays this week and don't have access to my SSH key.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine gesch&auml;ftliche Mitteilung im Sinne des EHUG.

      parent reply	other threads:[~2017-08-28 14:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25  7:53 Sichen Zhao
2017-08-25  7:36 ` [PATCH v3 2/2] Port strnstr.c to newlib Sichen Zhao
2017-08-25 17:56 ` [PATCH v3 1/2] Import strnstr.c from FreeBSD Corinna Vinschen
2017-08-25 18:07   ` Sebastian Huber
2017-08-28  8:57     ` Corinna Vinschen
2017-08-28 14:43       ` Sebastian Huber
2017-08-28 15:43         ` Corinna Vinschen
2017-08-28 14:59       ` Sebastian Huber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281337601.2137.1503931405363.JavaMail.zimbra@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).