* [PATCH] RTEMS: Adjust NGROUPS_MAX
@ 2014-11-17 9:04 Sebastian Huber
2014-11-17 12:49 ` Corinna Vinschen
0 siblings, 1 reply; 8+ messages in thread
From: Sebastian Huber @ 2014-11-17 9:04 UTC (permalink / raw)
To: newlib; +Cc: Sebastian Huber
We have NGROUPS == NGROUPS_MAX + 1. Make sure NGROUPS is even to not
waste memory.
newlib/ChangeLog
2014-11-17 Sebastian Huber <sebastian.huber@embedded-brains.de>
* libc/sys/rtems/sys/syslimits.h (NGROUPS_MAX): Adjust value so
that NGROUPS is even.
---
newlib/libc/sys/rtems/sys/syslimits.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/sys/rtems/sys/syslimits.h b/newlib/libc/sys/rtems/sys/syslimits.h
index 74c4dd2..2295afe 100644
--- a/newlib/libc/sys/rtems/sys/syslimits.h
+++ b/newlib/libc/sys/rtems/sys/syslimits.h
@@ -45,7 +45,7 @@
#define MAX_CANON 255 /* max bytes in term canon input line */
#define MAX_INPUT 255 /* max bytes in terminal input */
#define NAME_MAX 255 /* max bytes in a file name */
-#define NGROUPS_MAX 16 /* max supplemental group id's */
+#define NGROUPS_MAX 15 /* max supplemental group id's */
#ifndef OPEN_MAX
#define OPEN_MAX 64 /* max open files per process */
#endif
--
1.8.4.5
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RTEMS: Adjust NGROUPS_MAX
2014-11-17 9:04 [PATCH] RTEMS: Adjust NGROUPS_MAX Sebastian Huber
@ 2014-11-17 12:49 ` Corinna Vinschen
2014-11-17 12:55 ` Joel Sherrill
2014-11-17 12:58 ` Sebastian Huber
0 siblings, 2 replies; 8+ messages in thread
From: Corinna Vinschen @ 2014-11-17 12:49 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
On Nov 17 10:04, Sebastian Huber wrote:
> We have NGROUPS == NGROUPS_MAX + 1. Make sure NGROUPS is even to not
> waste memory.
>
> newlib/ChangeLog
> 2014-11-17 Sebastian Huber <...>
>
> * libc/sys/rtems/sys/syslimits.h (NGROUPS_MAX): Adjust value so
> that NGROUPS is even.
Sure? Doesn't that introduce a potential backward compat problem?
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RTEMS: Adjust NGROUPS_MAX
2014-11-17 12:49 ` Corinna Vinschen
@ 2014-11-17 12:55 ` Joel Sherrill
2014-11-17 13:37 ` Corinna Vinschen
2014-11-17 12:58 ` Sebastian Huber
1 sibling, 1 reply; 8+ messages in thread
From: Joel Sherrill @ 2014-11-17 12:55 UTC (permalink / raw)
To: newlib, Corinna Vinschen
On November 17, 2014 6:48:58 AM CST, Corinna Vinschen <vinschen@redhat.com> wrote:
>On Nov 17 10:04, Sebastian Huber wrote:
>> We have NGROUPS == NGROUPS_MAX + 1. Make sure NGROUPS is even to not
>> waste memory.
>>
>> newlib/ChangeLog
>> 2014-11-17 Sebastian Huber <...>
>>
>> * libc/sys/rtems/sys/syslimits.h (NGROUPS_MAX): Adjust value so
>> that NGROUPS is even.
>
>Sure? Doesn't that introduce a potential backward compat problem?
>
It could if we had binary distributions. All RTEMS users build from source.
>Corinna
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RTEMS: Adjust NGROUPS_MAX
2014-11-17 12:55 ` Joel Sherrill
@ 2014-11-17 13:37 ` Corinna Vinschen
2014-11-20 7:11 ` Sebastian Huber
0 siblings, 1 reply; 8+ messages in thread
From: Corinna Vinschen @ 2014-11-17 13:37 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
On Nov 17 06:55, Joel Sherrill wrote:
>
>
> On November 17, 2014 6:48:58 AM CST, Corinna Vinschen <vinschen@redhat.com> wrote:
> >On Nov 17 10:04, Sebastian Huber wrote:
> >> We have NGROUPS == NGROUPS_MAX + 1. Make sure NGROUPS is even to not
> >> waste memory.
> >>
> >> newlib/ChangeLog
> >> 2014-11-17 Sebastian Huber <...>
> >>
> >> * libc/sys/rtems/sys/syslimits.h (NGROUPS_MAX): Adjust value so
> >> that NGROUPS is even.
> >
> >Sure? Doesn't that introduce a potential backward compat problem?
> >
>
> It could if we had binary distributions. All RTEMS users build from source.
Ok, then please apply.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RTEMS: Adjust NGROUPS_MAX
2014-11-17 13:37 ` Corinna Vinschen
@ 2014-11-20 7:11 ` Sebastian Huber
2014-11-20 14:04 ` Corinna Vinschen
0 siblings, 1 reply; 8+ messages in thread
From: Sebastian Huber @ 2014-11-20 7:11 UTC (permalink / raw)
To: newlib
On 17/11/14 14:37, Corinna Vinschen wrote:
> On Nov 17 06:55, Joel Sherrill wrote:
>> >
>> >
>> >On November 17, 2014 6:48:58 AM CST, Corinna Vinschen<vinschen@redhat.com> wrote:
>>> > >On Nov 17 10:04, Sebastian Huber wrote:
>>>> > >>We have NGROUPS == NGROUPS_MAX + 1. Make sure NGROUPS is even to not
>>>> > >>waste memory.
>>>> > >>
>>>> > >>newlib/ChangeLog
>>>> > >>2014-11-17 Sebastian Huber <...>
>>>> > >>
>>>> > >> * libc/sys/rtems/sys/syslimits.h (NGROUPS_MAX): Adjust value so
>>>> > >> that NGROUPS is even.
>>> > >
>>> > >Sure? Doesn't that introduce a potential backward compat problem?
>>> > >
>> >
>> >It could if we had binary distributions. All RTEMS users build from source.
> Ok, then please apply.
Could someone please commit this for me.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RTEMS: Adjust NGROUPS_MAX
2014-11-20 7:11 ` Sebastian Huber
@ 2014-11-20 14:04 ` Corinna Vinschen
2014-11-20 14:43 ` Joel Sherrill
0 siblings, 1 reply; 8+ messages in thread
From: Corinna Vinschen @ 2014-11-20 14:04 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
On Nov 20 08:10, Sebastian Huber wrote:
>
> On 17/11/14 14:37, Corinna Vinschen wrote:
> >On Nov 17 06:55, Joel Sherrill wrote:
> >>>
> >>>
> >>>On November 17, 2014 6:48:58 AM CST, Corinna Vinschen<vinschen@redhat.com> wrote:
> >>>> >On Nov 17 10:04, Sebastian Huber wrote:
> >>>>> >>We have NGROUPS == NGROUPS_MAX + 1. Make sure NGROUPS is even to not
> >>>>> >>waste memory.
> >>>>> >>
> >>>>> >>newlib/ChangeLog
> >>>>> >>2014-11-17 Sebastian Huber <...>
> >>>>> >>
> >>>>> >> * libc/sys/rtems/sys/syslimits.h (NGROUPS_MAX): Adjust value so
> >>>>> >> that NGROUPS is even.
> >>>> >
> >>>> >Sure? Doesn't that introduce a potential backward compat problem?
> >>>> >
> >>>
> >>>It could if we had binary distributions. All RTEMS users build from source.
> >Ok, then please apply.
>
> Could someone please commit this for me.
I thought Joel would do it. Applied now.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RTEMS: Adjust NGROUPS_MAX
2014-11-20 14:04 ` Corinna Vinschen
@ 2014-11-20 14:43 ` Joel Sherrill
0 siblings, 0 replies; 8+ messages in thread
From: Joel Sherrill @ 2014-11-20 14:43 UTC (permalink / raw)
To: newlib
On 11/20/2014 8:04 AM, Corinna Vinschen wrote:
> On Nov 20 08:10, Sebastian Huber wrote:
>> On 17/11/14 14:37, Corinna Vinschen wrote:
>>> On Nov 17 06:55, Joel Sherrill wrote:
>>>>>
>>>>> On November 17, 2014 6:48:58 AM CST, Corinna Vinschen<vinschen@redhat.com> wrote:
>>>>>>> On Nov 17 10:04, Sebastian Huber wrote:
>>>>>>>>> We have NGROUPS == NGROUPS_MAX + 1. Make sure NGROUPS is even to not
>>>>>>>>> waste memory.
>>>>>>>>>
>>>>>>>>> newlib/ChangeLog
>>>>>>>>> 2014-11-17 Sebastian Huber <...>
>>>>>>>>>
>>>>>>>>> * libc/sys/rtems/sys/syslimits.h (NGROUPS_MAX): Adjust value so
>>>>>>>>> that NGROUPS is even.
>>>>>>> Sure? Doesn't that introduce a potential backward compat problem?
>>>>>>>
>>>>> It could if we had binary distributions. All RTEMS users build from source.
>>> Ok, then please apply.
>> Could someone please commit this for me.
> I thought Joel would do it. Applied now.
>
Thanks. I should have. :(
> Thanks,
> Corinna
>
--
Joel Sherrill, Ph.D. Director of Research & Development
joel.sherrill@OARcorp.com On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RTEMS: Adjust NGROUPS_MAX
2014-11-17 12:49 ` Corinna Vinschen
2014-11-17 12:55 ` Joel Sherrill
@ 2014-11-17 12:58 ` Sebastian Huber
1 sibling, 0 replies; 8+ messages in thread
From: Sebastian Huber @ 2014-11-17 12:58 UTC (permalink / raw)
To: newlib; +Cc: devel
On 17/11/14 13:48, Corinna Vinschen wrote:
> On Nov 17 10:04, Sebastian Huber wrote:
>> >We have NGROUPS == NGROUPS_MAX + 1. Make sure NGROUPS is even to not
>> >waste memory.
>> >
>> >newlib/ChangeLog
>> >2014-11-17 Sebastian Huber <...>
>> >
>> > * libc/sys/rtems/sys/syslimits.h (NGROUPS_MAX): Adjust value so
>> > that NGROUPS is even.
> Sure? Doesn't that introduce a potential backward compat problem?
Up to now there was no support for supplementary groups in RTEMS and
binary compatibility is not an issue for RTEMS between major releases.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-11-20 14:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-17 9:04 [PATCH] RTEMS: Adjust NGROUPS_MAX Sebastian Huber
2014-11-17 12:49 ` Corinna Vinschen
2014-11-17 12:55 ` Joel Sherrill
2014-11-17 13:37 ` Corinna Vinschen
2014-11-20 7:11 ` Sebastian Huber
2014-11-20 14:04 ` Corinna Vinschen
2014-11-20 14:43 ` Joel Sherrill
2014-11-17 12:58 ` Sebastian Huber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).