[PATCH] Don't override CFLAGS_FOR_TARGET when optimising for size

[PATCH] Don't override CFLAGS_FOR_TARGET when optimising for size

[Bob Dunlop]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi,

This patch prevents optmizing for space overriding any other
CFLAGS_FOR_TARGET that may already be set.  Found when trying
to set -fno-omit-frame-pointer for compatability with some
in house code.

Simply append the space optimisation flags to the CFLAGS_FOR_TARGET
set rather than replacing.

Tested compiling newlib-2.0.0 for ARM with crosstool-NG-1.20.0 and
GNU Make 3.82.

Same patch for 2.1.0.


-- 
        Bob Dunlop

[-- Attachment #2: 100-fix-optimising-for-space.patch --]
[-- Type: text/x-diff, Size: 335 bytes --]

--- newlib-2.0.0/config/mt-ospace-orig	2014-11-13 12:02:45.463578281 +0000
+++ newlib-2.0.0/config/mt-ospace	2014-11-13 12:03:01.409592374 +0000
@@ -1,3 +1,3 @@
 # Build libraries optimizing for space, not speed.
- CFLAGS_FOR_TARGET = -g -Os
- CXXFLAGS_FOR_TARGET = -g -Os
+ CFLAGS_FOR_TARGET += -g -Os
+ CXXFLAGS_FOR_TARGET += -g -Os

Re: [PATCH] Don't override CFLAGS_FOR_TARGET when optimising for size

[Jeff Johnston]

Hi Bob,

If you look at the note in the top-level MAINTAINER file, you will see that
changes to the config directory needs to be kept in sync with the GCC repo.

compile; depcomp; install-sh; missing; ylwrap;
config/
        Any global maintainer can approve changes to these
        files and directories, but they should be aware
        that they need to be kept in sync with their
        counterparts in the GCC repository.

I would suggest you submit your patch to the gcc list and then it should get
mirrored for newlib's repo.

-- Jeff J.

----- Original Message -----
> From: "Bob Dunlop" <bob.dunlop@xyzzy.org.uk>
> To: newlib@sourceware.org
> Sent: Thursday, November 13, 2014 9:02:06 AM
> Subject: [PATCH] Don't override CFLAGS_FOR_TARGET when optimising for size
> 
> Hi,
> 
> This patch prevents optmizing for space overriding any other
> CFLAGS_FOR_TARGET that may already be set.  Found when trying
> to set -fno-omit-frame-pointer for compatability with some
> in house code.
> 
> Simply append the space optimisation flags to the CFLAGS_FOR_TARGET
> set rather than replacing.
> 
> Tested compiling newlib-2.0.0 for ARM with crosstool-NG-1.20.0 and
> GNU Make 3.82.
> 
> Same patch for 2.1.0.
> 
> 
> --
>         Bob Dunlop
>