From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125789 invoked by alias); 15 Mar 2017 17:41:26 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 125763 invoked by uid 89); 15 Mar 2017 17:41:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL,BAYES_20,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=oar, H*F:U*joel, joel.sherrill@OARcorp.com, Hx-languages-length:1205 X-HELO: mx.coeval.ca Received: from mx.coeval.ca (HELO mx.coeval.ca) (184.75.211.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Mar 2017 17:41:23 +0000 Received: from localhost.localdomain.com (unknown [67.63.146.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.coeval.ca (Postfix) with ESMTPSA id 6E540436063; Wed, 15 Mar 2017 17:41:22 +0000 (UTC) From: Joel Sherrill To: newlib@sourceware.org Cc: Joel Sherrill Subject: [PATCH 2/2] libc/string/strsignal.c: Use of || not && lead to dead code. Date: Wed, 15 Mar 2017 17:41:00 -0000 Message-Id: <1489599679-1519-2-git-send-email-joel@rtems.org> In-Reply-To: <1489599679-1519-1-git-send-email-joel@rtems.org> References: <1489599679-1519-1-git-send-email-joel@rtems.org> X-SW-Source: 2017/txt/msg00173.txt.bz2 Coverity Id: 175333 --- newlib/libc/string/strsignal.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/newlib/libc/string/strsignal.c b/newlib/libc/string/strsignal.c index 94ae26d..e32c9a7 100644 --- a/newlib/libc/string/strsignal.c +++ b/newlib/libc/string/strsignal.c @@ -37,7 +37,7 @@ QUICKREF /* * Written by Joel Sherrill . * - * COPYRIGHT (c) 2010. + * COPYRIGHT (c) 2010, 2017. * On-Line Applications Research Corporation (OAR). * * Permission to use, copy, modify, and distribute this software for any @@ -49,8 +49,6 @@ QUICKREF * WARRANTY. IN PARTICULAR, THE AUTHOR MAKES NO REPRESENTATION * OR WARRANTY OF ANY KIND CONCERNING THE MERCHANTABILITY OF THIS * SOFTWARE OR ITS FITNESS FOR ANY PARTICULAR PURPOSE. - * - * $Id$ */ #include @@ -72,7 +70,7 @@ _DEFUN (strsignal, (signal), buffer = _REENT_SIGNAL_BUF(ptr); #if defined(SIGRTMIN) && defined(SIGRTMAX) - if ((signal >= SIGRTMIN) || (signal <= SIGRTMAX)) { + if ((signal >= SIGRTMIN) && (signal <= SIGRTMAX)) { siprintf (buffer, "Real-time signal %d", signal - SIGRTMIN); return buffer; } -- 1.8.3.1