[PATCH] really change time_t to 64-bit by default

[PATCH] really change time_t to 64-bit by default

[Michael Haubenwallner]

Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
---
 newlib/configure    | 2 +-
 newlib/configure.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/configure b/newlib/configure
index eb4b3b2..51b645a 100755
--- a/newlib/configure
+++ b/newlib/configure
@@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
   esac
  fi
 else
-  newlib_nano_malloc=
+  newlib_long_time_t=yes
 fi
 
 
diff --git a/newlib/configure.in b/newlib/configure.in
index 9d30481..af9b02e 100644
--- a/newlib/configure.in
+++ b/newlib/configure.in
@@ -247,7 +247,7 @@ AC_ARG_ENABLE(newlib-long-time_t,
     no)  newlib_long_time_t=no  ;;
     *)   AC_MSG_ERROR(bad value ${enableval} for newlib-long-time_t option) ;;
   esac
- fi], [newlib_nano_malloc=])dnl
+ fi], [newlib_long_time_t=yes])dnl
 
 NEWLIB_CONFIGURE(.)
 
-- 
2.10.2

Re: [PATCH] really change time_t to 64-bit by default

[Sebastian Huber]

On 26/09/17 11:07, Michael Haubenwallner wrote:

> Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
> ---
>   newlib/configure    | 2 +-
>   newlib/configure.in | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/newlib/configure b/newlib/configure
> index eb4b3b2..51b645a 100755
> --- a/newlib/configure
> +++ b/newlib/configure
> @@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
>     esac
>    fi
>   else
> -  newlib_nano_malloc=
> +  newlib_long_time_t=yes
>   fi

The default should be:

newlib_long_time_t=no

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

Re: [PATCH] really change time_t to 64-bit by default

[Freddie Chopin]

On Tue, 2017-09-26 at 11:49 +0200, Sebastian Huber wrote:
> The default should be:
> 
> newlib_long_time_t=no

See - I told you that the name is confusing, implying that previously
the time was "not-long".

Regards,
FCh

Re: [PATCH] really change time_t to 64-bit by default

[Sebastian Huber]

On 26/09/17 12:03, Freddie Chopin wrote:

> On Tue, 2017-09-26 at 11:49 +0200, Sebastian Huber wrote:
>> The default should be:
>>
>> newlib_long_time_t=no
> See - I told you that the name is confusing, implying that previously
> the time was "not-long".

Previously, the time_t was long. This is exactly what this option enforces.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

Re: [PATCH] really change time_t to 64-bit by default

[Freddie Chopin]

On Tue, 2017-09-26 at 12:53 +0200, Sebastian Huber wrote:
> Previously, the time_t was long. This is exactly what this option
> enforces.

Sure. I know it, you know it, but other people probably won't. That's
why it is extremely confusing - as you see - and that's why I proposed
to have sth like "--disable-long-long-time_t" or "--disable-int64_t-
time_t" or "--disable-64-bit-time_t" instead, which would possibly be
less confusing. These ./configure options are also meant for casual
users, which don't read newlib's mailing list.

Regards,
FCh

Re: [PATCH] Fix typo with newlib-long-time_t default value. (WAS: really change time_t to 64-bit by default)

[Michael Haubenwallner]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]



On 09/26/2017 11:49 AM, Sebastian Huber wrote:
> On 26/09/17 11:07, Michael Haubenwallner wrote:
> 
>> Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
>> ---
>>   newlib/configure    | 2 +-
>>   newlib/configure.in | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/newlib/configure b/newlib/configure
>> index eb4b3b2..51b645a 100755
>> --- a/newlib/configure
>> +++ b/newlib/configure
>> @@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
>>     esac
>>    fi
>>   else
>> -  newlib_nano_malloc=
>> +  newlib_long_time_t=yes
>>   fi
> 
> The default should be:
> 
> newlib_long_time_t=no
> 
I've just followed your title "Change time_t to 64-bit by default", but indeed
was confused by "can be forced to long with the --enable-newlib-long-time_t" in
your commit message.

However, I do not really care except for the typo.

Thanks!
/haubi/

[-- Attachment #2: 0001-Fix-typo-with-newlib-long-time_t-default-value.patch --]
[-- Type: text/x-patch, Size: 1121 bytes --]

From 53fa5ed5461788adf3ff04ee7eb05643c1b73c79 Mon Sep 17 00:00:00 2001
From: Michael Haubenwallner <michael.haubenwallner@ssi-schaefer.com>
Date: Tue, 26 Sep 2017 10:38:12 +0200
Subject: [PATCH] Fix typo with newlib-long-time_t default value.

Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
---
 newlib/configure    | 2 +-
 newlib/configure.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/configure b/newlib/configure
index eb4b3b2..9613214 100755
--- a/newlib/configure
+++ b/newlib/configure
@@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
   esac
  fi
 else
-  newlib_nano_malloc=
+  newlib_long_time_t=no
 fi
 
 
diff --git a/newlib/configure.in b/newlib/configure.in
index 9d30481..adce036 100644
--- a/newlib/configure.in
+++ b/newlib/configure.in
@@ -247,7 +247,7 @@ AC_ARG_ENABLE(newlib-long-time_t,
     no)  newlib_long_time_t=no  ;;
     *)   AC_MSG_ERROR(bad value ${enableval} for newlib-long-time_t option) ;;
   esac
- fi], [newlib_nano_malloc=])dnl
+ fi], [newlib_long_time_t=no])dnl
 
 NEWLIB_CONFIGURE(.)
 
-- 
2.10.2

Re: [PATCH] Fix typo with newlib-long-time_t default value. (WAS: really change time_t to 64-bit by default)

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

On Sep 26 12:31, Michael Haubenwallner wrote:
> >From 53fa5ed5461788adf3ff04ee7eb05643c1b73c79 Mon Sep 17 00:00:00 2001
> From: Michael Haubenwallner <michael.haubenwallner@ssi-schaefer.com>
> Date: Tue, 26 Sep 2017 10:38:12 +0200
> Subject: [PATCH] Fix typo with newlib-long-time_t default value.
> 
> Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
> ---
>  newlib/configure    | 2 +-
>  newlib/configure.in | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/newlib/configure b/newlib/configure
> index eb4b3b2..9613214 100755
> --- a/newlib/configure
> +++ b/newlib/configure
> @@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
>    esac
>   fi
>  else
> -  newlib_nano_malloc=
> +  newlib_long_time_t=no
>  fi
>  
>  
> diff --git a/newlib/configure.in b/newlib/configure.in
> index 9d30481..adce036 100644
> --- a/newlib/configure.in
> +++ b/newlib/configure.in
> @@ -247,7 +247,7 @@ AC_ARG_ENABLE(newlib-long-time_t,
>      no)  newlib_long_time_t=no  ;;
>      *)   AC_MSG_ERROR(bad value ${enableval} for newlib-long-time_t option) ;;
>    esac
> - fi], [newlib_nano_malloc=])dnl
> + fi], [newlib_long_time_t=no])dnl
>  
>  NEWLIB_CONFIGURE(.)
>  
> -- 
> 2.10.2
> 

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]