From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <newlib-return-17101-listarch-newlib=sources.redhat.com@sourceware.org>
Received: (qmail 95287 invoked by alias); 31 Jul 2019 23:13:37 -0000
Mailing-List: contact newlib-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <newlib.sourceware.org>
List-Subscribe: <mailto:newlib-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/newlib/>
List-Post: <mailto:newlib@sourceware.org>
List-Help: <mailto:newlib-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: newlib-owner@sourceware.org
Received: (qmail 95273 invoked by uid 89); 31 Jul 2019 23:13:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:7CQXWsJ, H*f:sk:7CQXWsJ
X-HELO: mailserver4.caci.com
Received: from mailserver4.caci.com (HELO mailserver4.caci.com) (204.194.76.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Jul 2019 23:13:36 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;  d=caci.com; i=@caci.com; q=dns/txt; s=caci;  t=1564614812; x=1596150812;  h=from:to:subject:date:message-id:references:in-reply-to:   content-transfer-encoding:mime-version;  bh=LXcqKO8MPSDxH40cKzSzaSMQ7Gj7BCgY5Jdn1vFflQE=;  b=Pf17acv4ZUFDGbimEIwcU8MnY4cNq6/0Pn0C30s/4Qo18BVwTr5dl0Oq   iZj68/yjkAUiWyOiWcBc4RKqpSyeCLxPXJLuOg3oYS6fIsJjUZI7vWy2h   IPckBq5eHIpUJe5dAXYR9A12GM1cQSozwITNDZCtoUJGxbZRADC16BBTx   KfP+9S3vAlz7ZPp66sSSCSX7drFyAg8fCUNcO7TFwPUPS4bWNNd4Pmsku   xfakTQEnCXnD73fJk3trph1ooS5AuULCTLbtnZ1d/kF7MeFZxo5BIP24V   UDDk3hJX6zkZ0qspsi5Ty/8tmsPrTsT6WNLlo3EPNXi9a2SkXPm3uMoT2   Q==;
Received: from cisexcasmb03-2b.caci.com ([10.21.200.65])  by mailserver4.caci.com with ESMTP/TLS/AES256-SHA; 31 Jul 2019 19:13:31 -0400
Received: from CISEXCASMB02-2B.caci.com (10.21.200.53) by CISEXCASMB03-2b.caci.com (10.21.200.65) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 31 Jul 2019 19:13:30 -0400
Received: from CISEXCASMB02-2B.caci.com ([fe80::4f0:f9df:5e28:c569]) by CISEXCASMB02-2b.caci.com ([fe80::4f0:f9df:5e28:c569%14]) with mapi id 15.00.1395.000; Wed, 31 Jul 2019 19:13:30 -0400
From: "Howland, Craig D. - US via newlib" <newlib@sourceware.org>
Reply-To: "Howland, Craig D. - US" <craig.howland@caci.com>
To: Newlib <newlib@sourceware.org>
Subject: Re: riscv fenv.h header file guard typo
Date: Wed, 31 Jul 2019 23:13:00 -0000
Message-ID: <1564614813047.69834@caci.com>
References: <CAF9ehCVdmayV2WM+7CQXWsJEuXrXdoZV8ufy_b-OwhLqVhhoZg@mail.gmail.com>
In-Reply-To: <CAF9ehCVdmayV2WM+7CQXWsJEuXrXdoZV8ufy_b-OwhLqVhhoZg@mail.gmail.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2019/txt/msg00393.txt.bz2


________________________________________
From: newlib-owner@sourceware.org <newlib-owner@sourceware.org> on behalf o=
f Joel Sherrill <joel@rtems.org>
Sent: Wednesday, July 31, 2019 6:47 PM
To: Newlib
Subject: riscv fenv.h header file guard typo

Hi

While working on the proposed fenv.h infrastructure support, I noticed that
the riscv fenv.h and sys/fenv.h appear to have very similar header guards
(only a trailing _ differentiates them).

/libc/machine/riscv/include/fenv.h:#ifndef _FENV_H
./libc/machine/riscv/sys/fenv.h:#ifndef _FENV_H_

Would it be better for sys/fenv.h to have _SYS_FENV_H?

--joel

Yes, better.