From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74361 invoked by alias); 7 Aug 2019 13:27:09 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 74353 invoked by uid 89); 7 Aug 2019 13:27:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=letter, newlibsourcewareorg, newlib@sourceware.org X-HELO: mailserver2.caci.com Received: from mailserver2.caci.com (HELO mailserver2.caci.com) (204.194.77.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Aug 2019 13:27:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=caci.com; i=@caci.com; q=dns/txt; s=caci; t=1565184423; x=1596720423; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=5ZeXrcnPWp4xkEfTE9mTCTzJ1T6mxzcgflVqDuo4Ins=; b=xwj4CZrmvRyhpVU2wPC1tuag17QRrLsC68Vwl/blFWaqK7mFJLyAUGIX /g0271qKK6k0wYEwHy8NXN6KjJRURG6NbRkXkYiKNVxh4Xa22bZllNUtx bHsx5hVWynyukxwZbs/QFuf6nuxixCc2svmsLeaQsOVfik5T/HBZLrsLT jhgKAeQ4NI0auO4lO50IGSE13TVQGNO/6Jn/n4ofWS0BE2SRiM+1Ko7R+ Sh4/M2gp4aRHRuvRw7doU461PQUtFSBEzWntDNnvz5rCDkX4Ln4RotEyf TpxshnpakR/pajrRt8/d14aK5QrUGqUEaz1igqM4ov35Ws51fyBqEE5aj A==; Received: from cisexcasmb01-2a.caci.com ([10.201.50.152]) by mailserver2.caci.com with ESMTP/TLS/AES256-SHA; 07 Aug 2019 09:26:57 -0400 Received: from CISEXCASMB02-2A.caci.com (10.201.50.154) by CISEXCASMB01-2a.caci.com (10.201.50.152) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 7 Aug 2019 09:26:56 -0400 Received: from CISEXCASMB02-2A.caci.com ([fe80::f116:6d04:460e:9018]) by CISEXCASMB02-2a.caci.com ([fe80::f116:6d04:460e:9018%12]) with mapi id 15.00.1395.000; Wed, 7 Aug 2019 09:26:56 -0400 From: "Howland, Craig D. - US via newlib" Reply-To: "Howland, Craig D. - US" To: "newlib@sourceware.org" Subject: Re: [PATCH v3 2/3] Add default implementation of fenv.h and all methods Date: Wed, 07 Aug 2019 13:27:00 -0000 Message-ID: <1565184419338.12435@caci.com> References: <1565118798-16391-1-git-send-email-joel@rtems.org> <1565118798-16391-3-git-send-email-joel@rtems.org>,<20190807083634.GA11632@calimero.vinschen.de> In-Reply-To: <20190807083634.GA11632@calimero.vinschen.de> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019/txt/msg00423.txt.bz2 > From: newlib-owner@sourceware.org on behalf= of Corinna Vinschen > Sent: Wednesday, August 7, 2019 4:36 AM > To: Joel Sherrill > Cc: newlib@sourceware.org > Subject: Re: [PATCH v3 2/3] Add default implementation of fenv.h and all = methods > > Hi Joel, > > On Aug 6 14:13, Joel Sherrill wrote: > > [...] > > +//#define FE_DIVBYZERO 0x00000001 > > +//#define FE_INEXACT 0x00000002 > > +//#define FE_INVALID 0x00000004 > > +//#define FE_OVERFLOW 0x00000008 > > +//#define FE_UNDERFLOW 0x00000010 > > + > > +//#define FE_ALL_EXCEPT \ > > + //(FE_DIVBYZERO|FE_INEXACT|FE_INVALID|FE_OVERFLOW|FE_UNDERFL= OW) > > +#define FE_ALL_EXCEPT 0 /* NONE SUPPORTED IN PLACEHOLDER TEMPLATE= */ > > + > > +/* > > + * The following macros are to be defined if the respective rounding > > + * direction is supported by the implementation via the fegetround() a= nd > > + * fesetround() functions, each with a unique positive value. > > + * > > + * FE_DOWNWARD > > + * FE_TONEAREST > > + * FE_TOWARDZERO > > + * FE_UPWARD > > + * > > + * Other implementation-specific rounding modes may be defined, and mu= st start > > + * with FE_ followed by a capital letter. > > + */ > > +//#define FE_DOWNWARD 1 > > +//#define FE_TONEAREST 2 > > +//#define FE_TOWARDZERO 3 > > +//#define FE_UPWARD 4 > > +=20=20=20 > > +/*=20 > > + * The following typedefs are required. See the C and POSIX standards = for > > + * details: > > + * > > + * fenv_t > > + * fexcept_t > > + */ > > +typedef size_t fenv_t;=20=20=20=20=20 > > +typedef size_t fexcept_t; >=20 > While these types are defined, the above macros are not. Wouldn't > it make sense to define all or nothing by default?=20 >=20 The standards require the types to be defined, but the individual macros are to be defined only if supported by the implementation. The default implementation being provided supports nothing, only returning error, so it is proper for them to not be defined. But having them there commented out to serve as a template seems to be a good thing. > > > Thanks, > Corinna Craig=20=20=20=20