From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from deimos.uberspace.de (deimos.uberspace.de [185.26.156.152]) by sourceware.org (Postfix) with ESMTPS id A77203858D3C for ; Thu, 24 Mar 2022 16:54:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A77203858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=jdoubleu.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jdoubleu.de Received: (qmail 6210 invoked by uid 989); 24 Mar 2022 16:54:27 -0000 Authentication-Results: deimos.uberspace.de; auth=pass (plain) Content-Type: multipart/mixed; boundary="------------svrFp78QNje09dryHrbyGiXF" Message-ID: <15d2933b-defd-f5d2-c402-7882dc20271c@jdoubleu.de> Date: Thu, 24 Mar 2022 17:54:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: [PATCH] fix testsuite Content-Language: de-DE To: newlib@sourceware.org References: From: jdoubleu In-Reply-To: X-Rspamd-Bar: - X-Rspamd-Report: BAYES_HAM(-2.999827) MIME_GOOD(-0.1) MIME_BASE64_TEXT_BOGUS(1) MIME_BASE64_TEXT(0.1) X-Rspamd-Score: -1.999827 Received: from unknown (HELO unkown) (::1) by deimos.uberspace.de (Haraka/2.8.28) with ESMTPSA; Thu, 24 Mar 2022 17:54:26 +0100 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, BODY_8BITS, GIT_PATCH_0, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 16:54:34 -0000 This is a multi-part message in MIME format. --------------svrFp78QNje09dryHrbyGiXF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I found the issue: newlib/testsuite/lib/passfail.exp was using a the function `newlib_target_compile` which is defined in newlib.exp but hasn't been included yet. I attached a patch. Still some tests fail to compile, but that seems more like an issue with the host environment or target board. Cheers --- 🙎🏻‍♂️ jdoubleu On 3/21/2022 4:37 PM, jdoubleu wrote: > Hi, > > I'm currently trying to run the newlib testsuite on my linux host. > Unforunately, it looks like the tests cannot be compiled (by DEJAGNU). > > I've followed the steps in > https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=newlib/README;h=97890b9d20ca0ac9f206d7a2334d55a3d7052289;hb=HEAD#l470 > to setup and configure my environment. > > I'm getting the following stack trace when I run `make check`: > ``` > $ make check > ... > make[1]: Entering directory '/path/to/newlib-cygwin/build' > Found expect: expect > Found runtest: runtest > /path/to/newlib-cygwin/build/testsuite > WARNING: Couldn't find tool init file > Test run by jdoubleu on Mon Mar 21 16:27:27 2022 > Target is x86_64-pc-linux-gnu > Host   is x86_64-pc-linux-gnu > >                 === newlib tests === > > Schedule of variations: >     unix > > Running target unix > Using /usr/share/dejagnu/baseboards/unix.exp as board description file > for target. > Using /usr/share/dejagnu/config/unix.exp as generic interface file for > target. > Using /path/to/newlib-cygwin/newlib/testsuite/config/default.exp as > tool-and-target-specific interface file. > WARNING: Assuming target board is the local machine (which is probably > wrong). > You may need to set your DEJAGNU environment variable. > Running /path/to/newlib-cygwin/newlib/testsuite/newlib.elix/elix.exp ... > Running /path/to/newlib-cygwin/newlib/testsuite/newlib.iconv/iconv.exp ... > ERROR: (DejaGnu) proc "newlib_target_compile > /path/to/newlib-cygwin/newlib/testsuite/newlib.iconv/iconvnm.c > /path/to/newlib-cygwin/build/testsuite/iconvnm.x executable {}" does not > exist. > The error code is TCL LOOKUP COMMAND newlib_target_compile > The info on the error is: > invalid command name "newlib_target_compile" >     while executing > "::tcl_unknown newlib_target_compile > /path/to/newlib-cygwin/newlib/testsuite/newlib.iconv/iconvnm.c > /path/to/newli..." >     ("uplevel" body line 1) >     invoked from within > "uplevel 1 ::tcl_unknown $args" > >                 === newlib Summary === > > make[1]: Leaving directory '/path/to/newlib-cygwin/build' > ``` > > Building the lib (`make`) works. > > I've also noticed, the docs are mentioning to run `make > check-target-newlib` (see > https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=newlib/README;h=97890b9d20ca0ac9f206d7a2334d55a3d7052289;hb=HEAD#l505), > which does not seem to exist. I could only run `check` which eventually > runs `check-DEJAGNU`. > > > Best regards --------------svrFp78QNje09dryHrbyGiXF Content-Type: text/plain; charset=UTF-8; name="0001-fix-testsuite.patch" Content-Disposition: attachment; filename="0001-fix-testsuite.patch" Content-Transfer-Encoding: base64 RnJvbSAzNjdiYWM1MTY3ZTNjMjRiMjYzMTBiYWZkNTlhMjZkYzU0OGEzYTMzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBqZG91YmxldSA8aGlAamRvdWJsZXUuZGU+CkRhdGU6 IFRodSwgMjQgTWFyIDIwMjIgMTc6NDk6MDggKzAxMDAKU3ViamVjdDogW1BBVENIXSBmaXgg dGVzdHN1aXRlCgotLS0KIG5ld2xpYi90ZXN0c3VpdGUvbGliL3Bhc3NmYWlsLmV4cCB8IDIg KysKIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9uZXds aWIvdGVzdHN1aXRlL2xpYi9wYXNzZmFpbC5leHAgYi9uZXdsaWIvdGVzdHN1aXRlL2xpYi9w YXNzZmFpbC5leHAKaW5kZXggNWU3ZWIyMS4uMmM5YWJmNiAxMDA2NDQKLS0tIGEvbmV3bGli L3Rlc3RzdWl0ZS9saWIvcGFzc2ZhaWwuZXhwCisrKyBiL25ld2xpYi90ZXN0c3VpdGUvbGli L3Bhc3NmYWlsLmV4cApAQCAtNCw2ICs0LDggQEAKICMgaXMgZnJlZWx5IGdyYW50ZWQsIHBy b3ZpZGVkIHRoYXQgdGhpcyBub3RpY2UgaXMgcHJlc2VydmVkLgogIwogCitsb2FkX2xpYiBu ZXdsaWIuZXhwCisKICMgbmV3bGliX3Bhc3NfZmFpbF9hbGwgY29tcGlsZXMgYW5kIHJ1bnMg YWxsIHRoZSBzb3VyY2UgZmlsZXMgaW4gdGhlCiAjIHRlc3QgZGlyZWN0b3J5LiBJZiBmbGFn IGlzIC14LCB0aGVuIHRoZSBzb3VyY2VzIHdob3NlIGJhc2VuYW1lcyBhcmUKICMgbGlzdGVk IGluIGV4Y2x1ZGVfbGlzdCBhcmUgbm90IGNvbXBpbGVkIGFuZCBydW4uCi0tIAoyLjM1LjEK Cg== --------------svrFp78QNje09dryHrbyGiXF--