From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id F155A384A033 for ; Mon, 21 Sep 2020 15:29:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F155A384A033 Received: by mail-wm1-x331.google.com with SMTP id s13so12534402wmh.4 for ; Mon, 21 Sep 2020 08:29:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=bLIMZFQccjfamSnpS+Ig3eMUmF8w52szIoW03t0xmuI=; b=PCQIalW/5aoLWZRw8D31JYZ2LNvYK00Qk72pBQxq8r4qd1W/05xSZVQAbrHa/uM5RW sNsyc3638uiygGG7OJlKldmM04hW16tgop19OW05XnIB9bxjADYQ21a3hry3EGqLJObg QxbRPubokK6w3t5sScMGg/hPz8FGFGzSlZhxTzbUsPC/LvF5inHq/zqq1ol+z22a82uS CbtswmJMGF8dYsUet1F7LtU0uJ5SU8hSbGh/GwMHAdRgysFNZ9njROQ92l/+INitB/NE WOiHNe31ZBbNErvuRyi2u2qo3wNryoM0luHNuzrKUuKiyf8eDhUoLsAj2OuCubf1YE81 RjHA== X-Gm-Message-State: AOAM531NTClznRImkKSvtsPwMojY0pxDvdHn+d7C029zHfkX9DWndvgA 2otoQvrn2Kb6A1pWNSMVBEQj+EcW9EqITQ== X-Google-Smtp-Source: ABdhPJzF8KEQm1G2z6a2z8S/yEY3FgjPz3VhWLIBo8NBGXa82WZTwE+npAgYKOuach+w23/KBUSFag== X-Received: by 2002:a05:600c:2189:: with SMTP id e9mr222399wme.8.1600702163633; Mon, 21 Sep 2020 08:29:23 -0700 (PDT) Received: from localhost.localdomain (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id y6sm20301576wrs.7.2020.09.21.08.29.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2020 08:29:23 -0700 (PDT) From: Christophe Lyon To: newlib@sourceware.org Subject: [PATCH] libc/include/math.h: Remove parameter name Date: Mon, 21 Sep 2020 15:29:21 +0000 Message-Id: <1600702161-13623-1-git-send-email-christophe.lyon@linaro.org> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 15:29:27 -0000 As discussed in GCC bug 97088 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in prototypes of library functions should use reserved names, or no name at all. This patch removes the 'x' parameter name from extern int __isinff (float); extern int __isinfd (double); extern int __isnanf (float); extern int __isnand (double); extern int __fpclassifyf (float); extern int __fpclassifyd (double); extern int __signbitf (float); extern int __signbitd (double); to avoid possible clashes with user code in case someone uses before including Newlib's math.h (or uses some other conflicting definition) --- newlib/libc/include/math.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h index 5e6155c..ba1a8a1 100644 --- a/newlib/libc/include/math.h +++ b/newlib/libc/include/math.h @@ -201,14 +201,14 @@ extern int isnan (double); # define math_errhandling (_MATH_ERRHANDLING_ERRNO | _MATH_ERRHANDLING_ERREXCEPT) #endif -extern int __isinff (float x); -extern int __isinfd (double x); -extern int __isnanf (float x); -extern int __isnand (double x); -extern int __fpclassifyf (float x); -extern int __fpclassifyd (double x); -extern int __signbitf (float x); -extern int __signbitd (double x); +extern int __isinff (float); +extern int __isinfd (double); +extern int __isnanf (float); +extern int __isnand (double); +extern int __fpclassifyf (float); +extern int __fpclassifyd (double); +extern int __signbitf (float); +extern int __signbitd (double); /* Note: isinf and isnan were once functions in newlib that took double * arguments. C99 specifies that these names are reserved for macros -- 2.7.4