From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic306-24.consmr.mail.ne1.yahoo.com (sonic306-24.consmr.mail.ne1.yahoo.com [66.163.189.86]) by sourceware.org (Postfix) with ESMTPS id 07D553858D37 for ; Sun, 20 Mar 2022 16:13:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 07D553858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=att.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=att.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=att.net; s=s1024; t=1647792837; bh=iJAYXKzb7l/h7W0oB7hH0Y7coQL/uAwJ5r6rQ5pInOM=; h=Date:From:Subject:To:References:From:Subject:Reply-To; b=bj15ATunscRpSGQo5xwKD414hYfkN0AEk/mdMPKL0mEdoIhqeYO8fKLQAhzotyCMKb2e6OB5Pw1bpwVuFGQkxE93U0hman8uHLwpnvG7MyEiFWkUHkO2SaD01bjG/whIVL60s+47YerwsBFe22HH9anHe71PwFzhuz3L+BHotgk= X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647792837; bh=aKvnlTF2+PXiximcE7GdcNt0XRTciYP8Ng1nqKOQ3F0=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=QEHWdeUBjQDaUlODiFz3KfqXbcCGxYaB24D6NPirHLca5b9UA+VdDv5DFF/6MLfTr1Jki+SmSz2/KYMd39SkGeVIzkp0k3Gb9GC1tUf0DN3EYXzkOcIsAqbH5HV01g6sihjPYy8WxZ/+9kIa+BOMYdL6xi0/cuYnGglGImiLZ2jAg1Tt0e0SvavXa/1l6MOKvyQgFX9uGaUnE66Dn4MYnvX8Yn6JkWuI1OvVAL/ohFJccpfi9b6DKHVno3djDwPF9mTm9LGivHsx2hps2PlD6ZEVxaJ2OChLumo1g7As0q8+kqBwusWdobJAJ/C702QNsgc7nanvtzz+X8xwHZEvfA== X-YMail-OSG: wFzrC3oVM1nCBaK4bNEYTRq7dgCQzs.9nf9JGCF4InOrxJLETq60bNTHiWyfGm1 2vmqfYs7Nj4ol.boWgkIjkiOTOnXB_y4MRAiE.fYYoSRmSgaA1mwVjzCYfl1XRSnT2gtsA1sn.AA nI0EOKl1YfNr8QkYIEH8s.7dMYVOIcjm2Zq2qijZFtVk7Swy2cuNY88xuJgDluSfAaPi38s8dIBW TgDgAIVIN1nhZ3HLaB8Bos_JRmCxLtx7g6_CQeEZgMnGDozBWCj9RA7GbhgXGtGGGGHp8I3daKL9 TN42MnKMT60GqWlCAhTr.3TDENnVNe_8_w9GC1_p_HcTP2I57tuOWFyJlsDehIc._1M96eOP1TOY dpmlr6nb8.ITG2JapE8hJ4_dWfg7AhwXD268n1UvNMKdR.zeDQXvJqI.wh8I0WGxujpEhI6KNO_3 lN08uFqPYkl3SH4SnPtpA7cJQO_7JZjQQTaA21P_syJpi6_dweocObmppS.r7YkzfnOMmDsn_KcE ju_UReY.XDqGHCqRJIuzisLBYrR1n8TqzVhEoo6vN2EtNgug62TLuay7O696gPjfF0Y0WQ4WfC0d 3z01coScYFjS.ne8K8EClnyCo7j5LwMgtEc3Is7RDoOd5cfomAArYpVwzsyfoEPVsduMoWxfZpe6 3ZksalLOxByoQ.IexopDuSNSTTNrlNLJtHS4dy3933TFvDOZl0cDjDLOrox3Dlu_pw57RQzo7p_v M2b5zuN_VzEOv.r53WMsDtanNAwArwEdsLiaoQBdhtDcINIVwATWAvRDxpODtbg00fMgfof_kKOI GMpW1VJ0rwFuhlMFtc08r1hQpoeHeo_ezCukkjfxEjDd.uzX111y2ZBKo2CHv0OgCmCG0Y0DIcv7 DV_RJDF7T4ol8wvG4kMaWnX25Z.nCWNA0CX1AedWpLj76OnHfc0JFvgVedUZWzMoNgh6_iwUDDYc XyxGbt4XwRV5dznncoNDgPY.tVROMTLmXVn4ty1P6h1p4ZEvBFxoDgmAisvU7lLr96hE8jMI5Mpd E6RwA6PsfqR2PQSrgYm9lJdDBgxRpZe90_WtBJ5fg8y7rdExo12m49OSi9.PHGEUNGJ07rbcJtvp ViTIxFmZ9ODhItiAjruWvKdy1XRrL85_vV3lOVc7jR5Dh9HsKFrialEKAvyxV8fnKQ3yOv30stpX .9ii.f7FPwL07NzkxcijGd8tT9iDNj9MSMr62d6moqBQjOld46uj.k5nXK5Kl6ypLTrzDHk4UmFc Kczq5k0xV7cs7WY9s.Ynz_CRChdAPceV_n1ilNahDpDP6_miyBd3WNzte7DTCvgu3DztbyvUCpya JoCJ.EkX_rDsIPFCJDw65Zqacx67g_bYwafR2I6sPgoH4LMEK_RsKSLa71pfkoOQHBSmO1rvouzl sE2yjgpxtVn7Oiz_4_m1LVXtMv0dIwycWsmxDNmMZPepEfoNO8gXFGJVRhKH5EScXnjqWnHp_x1k ggMsg6b5nZHBg.TYmkJFP3dK_usFPui4pbH2yowO.UfxvsL2_Vp3m4JqYQ5vp2GVXoD3BWgkiHuF J2gdZhamKmz3u_SB9R1EkX3rsdXJFnQvlO0JHmvr1k4hqGbnfsP._EWZjb7kQPBLdeXg6eqEaNCk YirTdetSbVypyPp9SYKm4KoLwr7zncI0GTfumbreOr_IfhyealkOkmPqCR1Lf7qZQaysCmrLQbDB 7tai6ppZyKnD83fmWg_4YOd2DItBRlPiFiNZO2cyQ8C3RsAP49Dr_WZCRzRe8qktgF1Sn.UeNMMd kMReDWjmD0xuheiIWOZBeyt5VzHQM05vnTPWv5MJgWUB80YOjfzC2rbJ8QpOczgXB1OLu2UkSA15 z1sp2hDOEazPDFWwF3Tay5AosFq6y15Gl46DroncnW_s3corThFPKpu.H8VDXI4Pb7kGgl9NjVEc ucRpBygeYin12cblQ4qLmgBV6IOUrGykE0uz9ktHgRCq1VxMroJwsu9SRF_JhsFGNPmvCEjoCK7P hDD2pUpOfADFiDrcKcE5jfti7cuubcebNRgqwm2a2sKKq4ifUh2zKrPVE.PN9lPRUNpIrV41ikt1 eIeuDUGiQ.mqoCYuus0ZXAboHbxcxiqnlNM1NJvpgh.dHPcVIQEBTGm7AECxA5U0AwwzSIHNJ2Lm wI2uxttZ9ycZMPzZ3qFuGsK97M3jZgqEEukNVQCG34h8QE1HxCPlsr6XEcElD6Tx8a4roZ8A8K0A x8zwNQNpZAnjSCSuG X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sun, 20 Mar 2022 16:13:57 +0000 Received: by kubenode532.mail-prod1.omega.ne1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 2a0d76107e6659bdad0359f6e71c78e8; Sun, 20 Mar 2022 16:13:55 +0000 (UTC) Date: Sun, 20 Mar 2022 12:13:54 -0400 From: Steven J Abner Subject: [PATCH v2] newlib: fix build with X-Mailer: pantheon-mail/1.0.8 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: quoted-printable References: <1647792834.2524.0.ref@smtp.mail.att.net> X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2022 16:14:00 -0000 I'm probably out of my depth, but along the same question: Why 0 return and not ((bool)(((unsigned long long)(a) * (b)) >> 32)) or prepend with '!!'? Steve >On 20 Mar 2022 07:52, Eric Bresie wrote: >> My C is a little rusty so forgive me up front if I=92m not reading=20 something quite right=85 >> >> Trying to understand the basic logic, the macro is expected to=20 return Boolean but the expression is assigning the multiplication=20 results to the size and then always returning 0 (false). Is that flow=20 correct? Should there be some form of =93=3D=3D=93 involved and/or ever=20 return non-zero number? >it returns a bool to indicate whether there was overflow, but the=20 result of the actual multiplication of the first two operands is stored in the 3rd=20 arg. >a return value of true means "the value overflowed", not "the=20 multiplication was successful". hence returning false is what the stub should do. =