public inbox for
 help / color / mirror / Atom feed
From: Brian Inglis <>
Subject: Re: [PATCH] newlib: libc: Optimize the string functions
Date: Tue, 13 Dec 2022 13:02:51 -0700	[thread overview]
Message-ID: <> (raw)

On 2022-08-16 05:08, Corinna Vinschen wrote:
> Hi Seija,
> Thanks for the patch.
> First of all, your patch is broken in terms of whitespaces and line
> breaks, so it can't be applied.  I suspect your MUA is doing that
> automatically.  You better provide the git patch as attachement, or
> change your MUA settings to leave whitespaces and line breaks alone.
...>   ...this one.
> Sorry, but I've given up after about half of the patch.  I don't see why
> this is only a single huge patch.  If there's any problem, multiple
> smaller patches are easier to understand, and easier to revert or
> bisect.
> Please resend this patch as a patchset, preferredly one file per patch
> including a matching commit message per patch.  The aforementioned
> bugfix should be a separate patch in the patchset.

Should we not also require some background info in PATCH 0/N on what compiler 
is "optimized" on what platform and by how much space and time?

If only some compilers or platforms, then code should go in conditionals.

Jeopardy: What is "the root of all evil?" Premature optimization.

Take care. Thanks, Brian Inglis			Calgary, Alberta, Canada

La perfection est atteinte			Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter	not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer	but when there is no more to cut
			-- Antoine de Saint-Exupéry

             reply	other threads:[~2022-12-13 20:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 20:02 Brian Inglis [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-08-12 21:11 Seija Kijin
2022-08-16 11:08 ` Corinna Vinschen
2022-08-12 21:09 Seija Kijin
2022-08-12 20:38 Seija Kijin
2022-08-11 18:56 doremylover456

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).