From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) by sourceware.org (Postfix) with ESMTPS id C68BD383A0DF for ; Tue, 13 Dec 2022 20:02:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C68BD383A0DF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=SystematicSw.ab.ca Authentication-Results: sourceware.org; spf=none smtp.mailfrom=systematicsw.ab.ca Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id 56mVpmKuhl2xS5BUKphZnz; Tue, 13 Dec 2022 20:02:52 +0000 Received: from [10.0.0.5] ([184.64.124.72]) by cmsmtp with ESMTP id 5BUJpt6HC3fOS5BUJpL3TE; Tue, 13 Dec 2022 20:02:52 +0000 X-Authority-Analysis: v=2.4 cv=J8G5USrS c=1 sm=1 tr=0 ts=6398da6c a=oHm12aVswOWz6TMtn9zYKg==:117 a=oHm12aVswOWz6TMtn9zYKg==:17 a=IkcTkHD0fZMA:10 a=C_5at5FLypn7SHYWJjwA:9 a=QEXdDO2ut3YA:10 Message-ID: <174d2c56-2d86-c476-23bc-9c26c46c46ae@SystematicSw.ab.ca> Date: Tue, 13 Dec 2022 13:02:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Reply-To: newlib@sourceware.org Subject: Re: [PATCH] newlib: libc: Optimize the string functions Content-Language: en-CA To: newlib@sourceware.org From: Brian Inglis Organization: Systematic Software Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfMaagsb+NwkO/hTrMO2ClODFhUPptsipGqfcKVDdN3Bc7M4BcNR+FxF+eg0kry9TmREzk2JLZ8r8I+/9hzX/2MmK/z110MHQn3FAT3vCL59TGiVivX3F ejYwJH5YZbxIr0Xp1RwPtX7vTpckjxESRAO9YhARYlIJo0dxMfrS1rfcZbkGV8o7/3+eozIKKguGAy64dAMp48I1VSnC/L1tyBk= X-Spam-Status: No, score=-1163.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-08-16 05:08, Corinna Vinschen wrote: > Hi Seija, > > Thanks for the patch. > > First of all, your patch is broken in terms of whitespaces and line > breaks, so it can't be applied. I suspect your MUA is doing that > automatically. You better provide the git patch as attachement, or > change your MUA settings to leave whitespaces and line breaks alone. ...> ...this one. > > Sorry, but I've given up after about half of the patch. I don't see why > this is only a single huge patch. If there's any problem, multiple > smaller patches are easier to understand, and easier to revert or > bisect. > > Please resend this patch as a patchset, preferredly one file per patch > including a matching commit message per patch. The aforementioned > bugfix should be a separate patch in the patchset. Should we not also require some background info in PATCH 0/N on what compiler is "optimized" on what platform and by how much space and time? If only some compilers or platforms, then code should go in conditionals. Jeopardy: What is "the root of all evil?" Premature optimization. -- Take care. Thanks, Brian Inglis Calgary, Alberta, Canada La perfection est atteinte Perfection is achieved non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut -- Antoine de Saint-Exupéry