From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic306-1.consmr.mail.bf2.yahoo.com (sonic306-1.consmr.mail.bf2.yahoo.com [74.6.132.40]) by sourceware.org (Postfix) with ESMTPS id 8DF6D388451F for ; Fri, 18 Mar 2022 08:30:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8DF6D388451F X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647592210; bh=jDeRIiDgy3LFN6QXpKLpmS/Rtq0ARvfIc3nyL5BLv8n=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=CNIpwWj3lNC0v78eiWoa3VV+0ROku8q565VP2GArwTQX0l/j9VPu0C0ML2Zl8M5wSDmtGJ6TDeVzifu+pgjikugJkFL/6Nm8apISIUfA4H51Cpi/8dtHRcCTlqbMWYNchqqD6szgvEpBrh1Qynkn1ywoR2qHu3xkgioACqqatrJIGYl6cjU81/L6LemwMyyscn1FwKo/6gXTuAhayn+MR2yv84dBOd+2qXmQaWnaF+hI5g8dBWqpbjlbNRDR4WS7tJkDMQY4aMAT2o6kxrqINeuxCoIXVroLVFHuaHOFSu6BthVIMFjh2D9pfP/PeYhY62FPHnE2IxdkSqxGVcPyUQ== X-YMail-OSG: mSa94zIVM1m4l0J7wmnfc93z6QyKJDyB.P258gjiQtPJYC7.K8Ze0uo86fW_aMd d_ZNxZycZYmoij0gIlg7BssvDlebNCX23Asl8oMVokydoDuSRMA27vncpdLZpU_CQv0IyFPDPAT9 QqZfJYfzgFe7MWqvSMs8dE3ZuvN.o9MPb.4hOJQ9k6q4sR_cHNYjhXQM0poCO27tjF728eSQPO0S sOS4yIooa9l3Y6JxoJoQiaAdMyQ2H6KloMnSvFOMg1OZrTiPF8I5saQZ5Y9fFujd3XmfLuKPwXE9 m9bzAG9hFu318_w3W_0l.fQbEJlaxcR9vWDTJ9BtO0FH80TDtsnY3RUQxhEaSIYFLds5UEfsZ.wv s.hA5GRBe7ti9a5ZJc4jATXnnQVcLNTwN6VIqEmnRazg6bnclPBHjrNad_1bJK9Jzfy2K_qtjYEJ xutmk0Ydh1q9QwyZ1yW8NF8UxRirfUyP1t1Yjz5BKKQxLVo2eKMXY4RlJZaornm_vTUEiruACv0H QUr9qk.IkzdlwGK8xgGfvT889H6I08.tUYJkkNobxGxtL_ZZlkuHlazQyCRKZSCTxiTb5Xu7pKc1 tftNkiyHS2kHxbZeGpLLglUMtq7X6EEb5n8tALj0i954F9i_C2kpAifV2f8nPU8mSrpfvnrneSIx VmS3wXfexFaTBRz.Db5NHq5vmUiQEFa9WhN04XQiBpCvfaNob6BDDF1CxCyNuvItjKzBcpMyiRdx fW7hIW6.HtD_sE4nW.fLPftoX94m2ajY2LDnEjq4_nFexSHWFVh5zIFhGfzlcLxT.6V2vIAp0FEr U05tz7Lio8oIgNMNStVaiK5eVKgBew_cXcL7pT2Smh6a4joo4F4zyng6JbMHs4g20Nv5SoWR0UwI d3D0c2m0PJurCU4B8F5Zom1pCIP9buFqZgWg8xiLQDDKwi0GsnbR1_j1ZNeI8TYjBQ5naOjn4fBQ 32PAFM5fPldI5vTMALtx0SFJ7s_Nw7vBcgn_md8ySS2TJIKKGG2Nf1ga7rFuoxWwiiVDod8nMV5U LkJ7ufJdI4.lnMEWdT26TOYCebeeMb_9hTHkFSzPxTJ41AYQVQMdBT_IGqsjFjZmpX5O7MFt6fti ya.M4zWPvjWeeFSqW4D10N3vuamGk2hUCNTDimIQswyC4X41OKDjeBn3XURurpzSZeb00BHjAP12 kc6YP.UwrJl0iWeF3MZkT04Y2zjWfDgJFWbeKdHLr7R6I2moxEOrh7kiIGCnZTUgzx0QOfjLmzck F_JU7XqlNc90vGvh.taM1YM84tYqDi_5ADJoOgu_clhKf5SmREwwZw2zimhsWzt4KXskUNW9P33T kNQ9Q99_0ZhE614tBcx.vbYJrqo0NvQipKDqSK1uoHlkoSUfJENcJZR.Y9Ead.RdSyZsHtnIN1CQ QMWSg6a2c2Jzw9dsbiYYZ0w8pJtJDRim3HJWTE5PFPdjhnT92kgXLVP9NCtK1lQAdY1LhWWvxceY Tt07XV6MIsmQ2Ivyxs16KAFYVZebr98aT.VkD2y8aKFbAqx6N2N1LILOIP1tnlYG.Zxbx48ZpY_G Y09t5Qgp8uPNB2mfpEf6RiMUO_YegBrIy9mo1f5NMQuNUB7PsiwTlWnfvPRM5t0rj2TR0EFZD_s2 4w9E19.43oiIsOOc0Pz8PKQQZfStV5T8ey7crgTCTM_DlhLszY0lNJxXnrQ3_6L0O3v9C.tiFlzq 3BUCKpOG9LXUUsYmUenjv6LJxxzo_7vtLZ8YlsJ5JcrenIGmhY7Q8MK9nJnszgxSjtcan.OkRiza 091xUenVe2IgzRuZs.6_dcQoisHVhAJnlImHZOVixRY9Iz_VFwITe5Eu7NpIMkI950B9LCWeJ6LH BpIGlyTXtoKGUjumXqtKIP6KEsN_o0DKrv1EuPcD44nUT0P2ALieFFunq0RuUeldQTNUEMOnRMEt bJeT1Rz6s5Ej16K3DyxYuIx_yIeu4ccZWO7ufxmOpOPFvpuNZs2kZJ2LpwUDWCimy21LLnFrNISp OiMfh9tz_HYUVpodoZ9i4IG1CvarHrKTyu0q4h1IOORMe.26FOZdF4tXo4cIImJtBupHel7kXJHi xRZgTBwYlA_1TuqtvdJy9vT6ubZW.a3JwlWYgZWaVdyGwgwp9tiwkVI39suUSDMo_5YP3Dvv5BKH jU3imOCiRLcDf4rVCV9K4CUtbakKxHgI.DnyhsIKvB1yIwiWnsAAM1rY18EFSxd86XyZSYrs_06s vNM6Bwbos6CsAGg7Llk.S8uDWlrehaUqWuVPviYCkCyr5I_3tfiuCpc9cIPCupav2U.LjfhGbDQ- - X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.bf2.yahoo.com with HTTP; Fri, 18 Mar 2022 08:30:10 +0000 Received: by kubenode503.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 9f88a793cad134a074d0f3e77beb9902; Fri, 18 Mar 2022 08:30:06 +0000 (UTC) Message-ID: <18777f5b-7e27-b0a0-5d8f-8ca0a30e07a6@yahoo.de> Date: Fri, 18 Mar 2022 09:30:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] newlib: fix build with <20220315032550.16502-1-vapier@gentoo.org> <2c68b0f8-03ad-d93d-dd35-002a66576ff8@foss.arm.com> <16551142-64aa-fdda-8f9e-7656c6b9390f@yahoo.de> From: "R. Diez" To: Corinna Vinschen , Mike Frysinger , Richard Earnshaw Cc: newlib@sourceware.org, sebastian.huber@embedded-brains.de In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.19894 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 08:30:13 -0000 >> It's not just about old GCC, it's about any C compiler that doesn't have >> that builtin. > > Well, I guess, GTG then. Let's see if I understand the situation: You are committing a replacement implementation of __builtin_mul_overflow() for older GCC versions and for any other compiler which does not have it. The only significant extra feature about that function is the detection of integer overflow. The implementation lives in libc/include/sys/cdefs.h , so it is accessible not just by some special malloc code which should never overflow because targets wouldn't have that much memory or whatever. The replacement implementation is known to be broken and therefore poses a risk on anybody relying on the original, documented behaviour. There are no mitigation measures. There is not even a comment next to the replacement implementation that states it is broken. And you guys are fine with that. Is that correct? Regards, rdiez