From: Stefan Tauner <stefan.tauner@gmx.at>
To: newlib@sourceware.org
Cc: Jordi Sanfeliu <jordi@fibranet.cat>
Subject: Re: [PATCH] Fix getlogin() to check only stdin to get a valid tty
Date: Thu, 13 Jul 2023 23:12:49 +0200 [thread overview]
Message-ID: <1M7sHo-1qGE7t0vwY-0053lN@mail.gmx.net> (raw)
In-Reply-To: <61101fc8-fc4f-8781-98a4-d84be32c126b@fibranet.cat>
On Thu, 13 Jul 2023 18:57:32 +0200
Jordi Sanfeliu via Newlib <newlib@sourceware.org> wrote:
> - if (((tty = ttyname (0)) == 0)
> - || ((tty = ttyname (1)) == 0)
> - || ((tty = ttyname (2)) == 0))
> - return 0;
> + if ((tty = ttyname (0)) == 0)
> + if ((tty = ttyname (1)) == 0)
> + if ((tty = ttyname (2)) == 0)
> + return 0;
IMHO the bug arose simply because of a || vs. && confusion. You can
just replace the || with && and have exactly the same effect as this
patch but it would be more customary.
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
next prev parent reply other threads:[~2023-07-13 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 17:33 Jordi Sanfeliu
2023-07-12 18:50 ` Torbjorn SVENSSON
2023-07-12 20:06 ` Brian Inglis
2023-07-13 16:26 ` Torbjorn SVENSSON
2023-07-13 8:06 ` Jordi Sanfeliu
2023-07-13 16:25 ` Torbjorn SVENSSON
2023-07-13 16:57 ` Jordi Sanfeliu
2023-07-13 19:01 ` Jeff Johnston
2023-07-17 7:54 ` Corinna Vinschen
2023-07-13 21:12 ` Stefan Tauner [this message]
2023-07-17 19:06 ` Jeff Johnston
2023-07-18 5:57 ` Jordi Sanfeliu
2023-07-18 7:08 ` Jordi Sanfeliu
2023-07-18 17:44 ` Jeff Johnston
2023-07-18 18:59 ` Jordi Sanfeliu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1M7sHo-1qGE7t0vwY-0053lN@mail.gmx.net \
--to=stefan.tauner@gmx.at \
--cc=jordi@fibranet.cat \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).