From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 41C683858D1E for ; Thu, 13 Jul 2023 21:13:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41C683858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.at Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.at DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1689282771; x=1689887571; i=stefan.tauner@gmx.at; bh=SBBS+XE6b2qnmLx/cQ5od2vzPLzpu2hbEi38KES5TNU=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=oJ3zSYnFxbfxqlEyrAqWlSTh+oIriaZaEOZE28vVYRJUHzsVOKqSFWc/aHnkWZ3EL/sAdDK yLwLXwdxGZKevfgoczMT7H+xNiPfdTjaI69oEF3qlX0Q+vTEAPF8nVfoa6YATOzYSRqW43AJG j8g/y+p5uowwCTprHqmRpLeCyjKrFLrZTnEoGYXni7WMs/ftOPTmYU3aM4i7UwAfWqSVsZWpQ 0z7flBO6vjIqjUixdzNurOB1fgepZCTZ1e2kKHj+sQNaRwg/vF2WyqC+vNGcDu05SB5RdV+3R ZQa3YnaD6qJ5eThlLXXe1ir2FRDf1C8HKBSIqYiogiVsK/mPFUBw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from legacy ([80.109.83.31]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MjS9I-1peuFd0TTm-00kzDx; Thu, 13 Jul 2023 23:12:51 +0200 Date: Thu, 13 Jul 2023 23:12:49 +0200 From: Stefan Tauner To: newlib@sourceware.org Cc: Jordi Sanfeliu Subject: Re: [PATCH] Fix getlogin() to check only stdin to get a valid tty In-Reply-To: <61101fc8-fc4f-8781-98a4-d84be32c126b@fibranet.cat> References: <1de3b3ee-7dd8-db16-6e17-365dbd9fde84@fibranet.cat> <74633613-8420-5ad6-2882-6ad14066f781@foss.st.com> <9ad091f5-4ca9-6410-e990-0cd4f1ece86e@foss.st.com> <61101fc8-fc4f-8781-98a4-d84be32c126b@fibranet.cat> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID: <1M7sHo-1qGE7t0vwY-0053lN@mail.gmx.net> X-Provags-ID: V03:K1:OvTAn2iaoMlC+sQxmeKnP+ZdHzoXFfgo/6oD/NbGPDg0Ykc6ct3 F6Pn2f+YJDqwYclmZA4nlU6ZiHakBD3qhYIARFCNSRmvVEUYYu4bbkwOuF68cg3Yd9ZydIe 0UWQgLj/dAUmQMbGTen+2Qq9tSwapx1mczwa1lzlxJ7WjPDo3qZfFsEoAKodGfZG0UKHziK ELhYp4fsEDTjtP9aEqNBg== UI-OutboundReport: notjunk:1;M01:P0:VDTDQw9c5W0=;ua4qXbyUDrkV4Ub9YlzbZOXPcYs 9O8NwLjSkZT1x6mtlvzA1DIUWmXsI4m3RA/Mbp9o93eJDnbm8dMfAP6Xaj+BlwDgEal+F6t9O RdfhjLoCqzgzerrlPh3LWshPZw2X2WKhgsOy4zjc1xJG/8mdlLgcoIUOVZm0AF/V28ZS/lG1s kDOEC4iDbFZyMIRcDMlVSI6aOW8E6V6dLHYyyEnONwWigMtSc4Ij6m+2n5fz20luU0jvxvhYo ///4AxwSUulZWjRSh3DllXk5oTwZG6SSjpX7WtX5gqVRyqhsFZQODTQSTPfuxi6LumCgxRvCQ n6f+OM3DuU86G8kyuvXKnUQ1VWsFreZzrr5A/RjXte9m47o1XW+RDdvHAtaR1DD0pZQCdCsEu 1/eHwCzoAW+Pa3PBaKQldLLR23qHz1MQEkwmI0ere2393aHN8regOT6oZV1Lh7dnK0d0MvKjI QNumz6KS4Rc+OyuCb482bM1pJ3iI6BfUB+mn6UAlBIEerruSRmvuykH7SL8pLLaWQCqufoCLr aln8HqmS4xkdIR/ntkCMXw1xbbZGSIAyxXg0J5rrRyfssJnShNQMHvlRgFYwf4XVvh5PZnXu0 7vixoQ6y1Mqn9P5wMY1z52yw0Z2/A8/qaB/KD/bfKTAmKRo7V2AXVC2TJv/cNVHVG2Du9N1tt MbwmG0rttFASDZwJBE2eIWlqm48JHQwLi94PZ8gykVf/g/B2kJFAzl4ijqNaY8LQXj3MaMa2/ N4YzrakqTzquZVPRSyHrU16iwSsHbFuD6PNsNKVK0hfLVJpwUF86WB5SpSRw1kjfHfhNYggcZ cIG+mQ2KM7oz2HzWVlKEkCMqCYdnMk0JCySE+Q/gsjMvGJAdZrYv5dPP6cK/m8JwYUDBD8wlY xlTFTXphb0/N7heL+A6WwfPo19S3eyxJxg+GMQTPuOQNIDkBDYPdlRc97e1JkB1UQrdwxn7y0 3Tt2pud0YpRO6tSbn9zy5uzgXJ4= X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 13 Jul 2023 18:57:32 +0200 Jordi Sanfeliu via Newlib wrote: > - if (((tty =3D ttyname (0)) =3D=3D 0) > - || ((tty =3D ttyname (1)) =3D=3D 0) > - || ((tty =3D ttyname (2)) =3D=3D 0)) > - return 0; > + if ((tty =3D ttyname (0)) =3D=3D 0) > + if ((tty =3D ttyname (1)) =3D=3D 0) > + if ((tty =3D ttyname (2)) =3D=3D 0) > + return 0; IMHO the bug arose simply because of a || vs. && confusion. You can just replace the || with && and have exactly the same effect as this patch but it would be more customary. --=20 Kind regards/Mit freundlichen Gr=C3=BC=C3=9Fen, Stefan Tauner