From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] Correct argument to __get_current_locale.
Date: Mon, 28 Nov 2016 09:35:00 -0000 [thread overview]
Message-ID: <20161128093517.GA3778@calimero.vinschen.de> (raw)
In-Reply-To: <7a3d1e4f-acf6-f1a7-d357-0dc2aa45599e@ourairquality.org>
[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]
On Nov 27 12:13, Douglas wrote:
> ---
> newlib/libc/locale/locale.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I noticed a change made to newlib locale.c 2016-08-25 and it seems
> to have resulted in the function __get_current_locale not being
> inlined which in turn breaks linking for my project because
> this function is not defined. The line is
>
> return __get_current_locale (_REENT)->ctype_ptr;
>
> Do you think the _REENT argument needs to be removed
> or is __get_current_locale the wrong function?
>
> diff --git a/newlib/libc/locale/locale.c b/newlib/libc/locale/locale.c
> index b7ced4d..8572821 100644
> --- a/newlib/libc/locale/locale.c
> +++ b/newlib/libc/locale/locale.c
> @@ -996,7 +996,7 @@ __locale_ctype_ptr_l (struct __locale_t *locale)
> const char *
> __locale_ctype_ptr (void)
> {
> - return __get_current_locale (_REENT)->ctype_ptr;
> + return __get_current_locale ()->ctype_ptr;
> }
Patch applied, thank you. I also applied a patch which adds a "void"
parameter to the inline functions __get_current_locale and
__get_C_locale. Without that parameter, no warning is emitted for the
above, pretty obvious bug. I have constant trouble remembering that
foo() is not the same as foo(void). Duh.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-11-28 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 1:13 Douglas
2016-11-28 9:35 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128093517.GA3778@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).