[PATCH] Add missing crt0 symbols for RTEMS

[PATCH] Add missing crt0 symbols for RTEMS

[Sebastian Huber]

In order to enable proper detection of thread-local storage availability
we have to provide some symbols on ARM.

Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
---
 newlib/libc/sys/rtems/crt0.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/newlib/libc/sys/rtems/crt0.c b/newlib/libc/sys/rtems/crt0.c
index 1a0a055..769cde7 100644
--- a/newlib/libc/sys/rtems/crt0.c
+++ b/newlib/libc/sys/rtems/crt0.c
@@ -188,6 +188,11 @@ RTEMS_STUB(_VOID, _free_r(struct _reent *r, _PTR *p), { })
 /* stubs for functions required by libc/stdlib */
 RTEMS_STUB(void, __assert_func(const char *file, int line, const char *failedexpr), { })
 
+#if defined(__arm__)
+RTEMS_STUB(void, __aeabi_read_tp(void), { })
+RTEMS_STUB(void *, __tls_get_addr(const void *ti), { })
+#endif
+
 /* The PowerPC expects certain symbols to be defined in the linker script. */
 
 #if defined(__PPC__)
-- 
1.8.4.5

Re: [PATCH] Add missing crt0 symbols for RTEMS

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

Hi Sebastian,

On Dec  5 08:22, Sebastian Huber wrote:
> In order to enable proper detection of thread-local storage availability
> we have to provide some symbols on ARM.
> 
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
>  newlib/libc/sys/rtems/crt0.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/newlib/libc/sys/rtems/crt0.c b/newlib/libc/sys/rtems/crt0.c
> index 1a0a055..769cde7 100644
> --- a/newlib/libc/sys/rtems/crt0.c
> +++ b/newlib/libc/sys/rtems/crt0.c
> @@ -188,6 +188,11 @@ RTEMS_STUB(_VOID, _free_r(struct _reent *r, _PTR *p), { })
>  /* stubs for functions required by libc/stdlib */
>  RTEMS_STUB(void, __assert_func(const char *file, int line, const char *failedexpr), { })
>  
> +#if defined(__arm__)
> +RTEMS_STUB(void, __aeabi_read_tp(void), { })
> +RTEMS_STUB(void *, __tls_get_addr(const void *ti), { })
> +#endif
> +
>  /* The PowerPC expects certain symbols to be defined in the linker script. */
>  
>  #if defined(__PPC__)
> -- 
> 1.8.4.5

Shall I commit this even without the crt0.o problem fixed?


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] Add missing crt0 symbols for RTEMS

[Sebastian Huber]

On 05/12/16 11:33, Corinna Vinschen wrote:
> Hi Sebastian,
>
> On Dec  5 08:22, Sebastian Huber wrote:
>> >In order to enable proper detection of thread-local storage availability
>> >we have to provide some symbols on ARM.
>> >
>> >Signed-off-by: Sebastian Huber<sebastian.huber@embedded-brains.de>
>> >---
>> >  newlib/libc/sys/rtems/crt0.c | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> >
>> >diff --git a/newlib/libc/sys/rtems/crt0.c b/newlib/libc/sys/rtems/crt0.c
>> >index 1a0a055..769cde7 100644
>> >--- a/newlib/libc/sys/rtems/crt0.c
>> >+++ b/newlib/libc/sys/rtems/crt0.c
>> >@@ -188,6 +188,11 @@ RTEMS_STUB(_VOID, _free_r(struct _reent *r, _PTR *p), { })
>> >  /* stubs for functions required by libc/stdlib */
>> >  RTEMS_STUB(void, __assert_func(const char *file, int line, const char *failedexpr), { })
>> >  
>> >+#if defined(__arm__)
>> >+RTEMS_STUB(void, __aeabi_read_tp(void), { })
>> >+RTEMS_STUB(void *, __tls_get_addr(const void *ti), { })
>> >+#endif
>> >+
>> >  /* The PowerPC expects certain symbols to be defined in the linker script. */
>> >  
>> >  #if defined(__PPC__)
>> >-- 
>> >1.8.4.5
> Shall I commit this even without the crt0.o problem fixed?

Yes, please.

It problem seems to be GCC related:

https://gcc.gnu.org/ml/gcc/2016-12/msg00010.html

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

Re: [PATCH] Add missing crt0 symbols for RTEMS

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

On Dec  5 15:34, Sebastian Huber wrote:
> On 05/12/16 11:33, Corinna Vinschen wrote:
> > Hi Sebastian,
> > [...]
> > Shall I commit this even without the crt0.o problem fixed?
> 
> Yes, please.

Done.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]