public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: stdatomic.h broken on GCC-5.4.0 (error: request for member ‘__val’ in something not a structure or union)
Date: Thu, 23 Feb 2017 10:19:00 -0000	[thread overview]
Message-ID: <20170223101917.GI23946@calimero.vinschen.de> (raw)
In-Reply-To: <20170223101734.GH23946@calimero.vinschen.de>

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

On Feb 23 11:17, Corinna Vinschen wrote:
> On Feb 23 08:13, Sebastian Huber wrote:
> > This file worked before GCC shipped its own stdatomic.h. You should use the
> > GCC provided stdatomic.h. Maybe we should remove the stdatomic.h from
> > Newlib.
> 
> We should continue to provide it for older GCC versions.  We could
> do something like
> 
>   #if __GNUC_PREREQ__(X,Y)
>   #undef _STDATOMIC_H_

The undef is apparently not even required.  GCC uses _STDATOMIC_H without
trailing underscore.

>   #include_next <stdatomic.h>
>   #else
>   [rest of our own stdatomic.h]
>   #endif
> 
> X.Y would be the 1st gcc version providing its own stdatomic.h


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2017-02-23 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 17:32 Joakim Nohlgård
2017-02-23  7:13 ` Sebastian Huber
2017-02-23 10:17   ` Corinna Vinschen
2017-02-23 10:19     ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223101917.GI23946@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).