From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75948 invoked by alias); 22 Mar 2017 09:06:58 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 75880 invoked by uid 89); 22 Mar 2017 09:06:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Older X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Mar 2017 09:06:55 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 201658FCE4 for ; Wed, 22 Mar 2017 09:06:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 201658FCE4 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 201658FCE4 Received: from calimero.vinschen.de (ovpn-117-18.ams2.redhat.com [10.36.117.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA06E1980F for ; Wed, 22 Mar 2017 09:06:55 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 2CDACA80CF2; Wed, 22 Mar 2017 10:06:54 +0100 (CET) Date: Wed, 22 Mar 2017 09:06:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] ARM: Fix IEEE-754 sqrt implementation Message-ID: <20170322090654.GA27402@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <1490107654-24798-1-git-send-email-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline In-Reply-To: <1490107654-24798-1-git-send-email-sebastian.huber@embedded-brains.de> User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017/txt/msg00209.txt.bz2 --jI8keyz6grp/JLjh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1097 On Mar 21 15:47, Sebastian Huber wrote: > Older GCC (e.g. 4.9.3) seem to define __ARM_FP even in case soft-float > is used. > --- > newlib/libm/machine/arm/e_sqrt.c | 2 +- > newlib/libm/machine/arm/ef_sqrt.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/newlib/libm/machine/arm/e_sqrt.c b/newlib/libm/machine/arm/e= _sqrt.c > index 8754b9f..6f3eb83 100644 > --- a/newlib/libm/machine/arm/e_sqrt.c > +++ b/newlib/libm/machine/arm/e_sqrt.c > @@ -24,7 +24,7 @@ > * SUCH DAMAGE. > */ >=20=20 > -#if __ARM_FP & 0x8 > +#if (__ARM_FP & 0x8) && !defined(__SOFTFP__) > #include >=20=20 > double > diff --git a/newlib/libm/machine/arm/ef_sqrt.c b/newlib/libm/machine/arm/= ef_sqrt.c > index 81c29f1..3a1ba6c 100644 > --- a/newlib/libm/machine/arm/ef_sqrt.c > +++ b/newlib/libm/machine/arm/ef_sqrt.c > @@ -24,7 +24,7 @@ > * SUCH DAMAGE. > */ >=20=20 > -#if __ARM_FP & 0x4 > +#if (__ARM_FP & 0x4) && !defined(__SOFTFP__) > #include >=20=20 > float > --=20 > 1.8.4.5 Pushed. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJY0j6tAAoJEPU2Bp2uRE+gZ04P/3hWZyGTgEmfqAdZwjPWkSK3 p+z4m0X7lNUVMGkz0w4iqx1Cz4tmro9eCr3a+lr1f1OTWTPncOlDQx2zpHvulgpG 0qBt+WdZbD05dX99qKCPAEBrO+0pzNnNTeL992B951CNfJqrCzrjuNMqE3FBQ7hD NWJ5ECysN1d8QKE4dZygs4FBgxWzMzmuwFuHEpwPohT+Ito7ZJ2UYChL3sUARka1 e7+MjVxNqQg0svIN4qlmjJZdHxnHxzxqHrt0pkWEb2lvc7xPhe+E2BL3QwiMikIg Offk02sH8hBGw/Ju2ByguWw+U5B0Yq1f8QmnMOC+bGKVTcIVV17AkM1Xb+NNzejp mUr0fR1ZoMTApk8simYu2uNm6BTfrlFSNuFMYdOpaKNgsQMT2O4qbjXw5VPCWLVx IdpRWRR9SNlnqBQ4New64sY9z79YexgfiEuKB83tHo8TtP66o2lvorHj1DLdpc3w fOh2itOpt/HCFRdU6+fK9lBePQL7VPhOAlLORe+ywndHfTuwnaeLMYtbh+8ekkpt 8Ky6eqxnbOWLRGQRLvNLZF6xPA2Nij0xpsDxDr5zhMf7oxQn9D9H9AQIkgtmrtnM pZ8Z9hLtm559KwDQTNOQEjiqT7MFncplF7HaecisxsInN6JxWrB4ibAgan+wS2EN yDlKB5zV7YPnahGWpDVg =n645 -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh--