From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117913 invoked by alias); 26 Apr 2017 08:24:45 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 117827 invoked by uid 89); 26 Apr 2017 08:24:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HTo:D*it, Hx-languages-length:623, H*R:D*sourceware.org, HX-Greylist:Wed X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Apr 2017 08:24:35 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C54217F4D3; Wed, 26 Apr 2017 08:24:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C54217F4D3 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C54217F4D3 Received: from calimero.vinschen.de (ovpn-116-117.ams2.redhat.com [10.36.116.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0DA7560BE5; Wed, 26 Apr 2017 08:24:28 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 4632DA8034D; Wed, 26 Apr 2017 10:24:27 +0200 (CEST) Date: Wed, 26 Apr 2017 08:24:00 -0000 From: Corinna Vinschen To: Giacomo Tesio Cc: newlib@sourceware.org Subject: Re: Uninitialized structure in printing functions Message-ID: <20170426082427.GD12712@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Giacomo Tesio , newlib@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bKyqfOwhbdpXa4YI" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017/txt/msg00317.txt.bz2 --bKyqfOwhbdpXa4YI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 585 On Apr 21 19:03, Giacomo Tesio wrote: > Hi, during the port to Jehanne, I had issues with the uninitialized > uio structure in several printing functions. >=20 > The attached patch fixes them. I'm puzzled what problem you're solving. I inspected the code in question and the uio structure is always filled with values for all three members before using it. Setting uio to 0 in all these places looks gratuitous. Can you please explain what exactly you're observing and how setting uio to all 0 solved this problem?=20=20 Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --bKyqfOwhbdpXa4YI Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZAFk7AAoJEPU2Bp2uRE+gWREP/A+EhIBal3kgiJOPQUBe05rK 1e9ETUlQ1/l/dIyynTDqAM4pjC8dDlK6TjCk0cIs9w4vPhYPiaNGmKOI3fSHX3oa DkZZJQ65DQLGgoqQJQ03HuJGVm65vl7rjWRfqZgA55eHn1CaRAqc51dq2HTakkaE k931aMVo9xuLMvXccd6xwFQ8yTSJAtj9kp6/MbkR0JUYmpKuhk9onVcQF/O2ecaE qaTJNUeIdkSbblg8AIWuyd32gd0g80cJU1DbQJ+MzDLL5Z6CYZxOHVOPu+NROpXV WCmNzX2vJHqtEwKc1sATAgkPPal42dJjAQqOKI4unzg9GG2kHo6fltVlUt7bm5zk WDibp4ublGDdRwY0yAmjD4UbYtUxInCp3m9C2vq0GizzYh2el+KtoTDj/FujjlPB VTaVmOFwv9zAioqFb3wFpHR6sXKOEZXe59A1e+pr3Z0ucotn02zPtGtkgeZ6WUi5 UVdPHlgkLmj9Z3vgc8rCYzwOsKzcEGuyorJFw+0h6y8GrW0VStnx3/Mr0RRY1hJW P6TrDqJ7r2Uu6DGcnTqv5ixtAmehfyiE5gi0ffgfHEtB4AVxFxFYIHkULQpW4FXz Udkcf4D5o18PpJBETCF7o7qT8geaD36i0fvyXDiz1M4OImyrV+XVUHavvws4q+Ao cjllkz0CS0WJBXtHABiM =FFm3 -----END PGP SIGNATURE----- --bKyqfOwhbdpXa4YI--