From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128143 invoked by alias); 26 Apr 2017 08:31:00 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 128124 invoked by uid 89); 26 Apr 2017 08:30:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:HE1PR08, Binderman, binderman, UD:fname X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Apr 2017 08:30:58 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2F4AB7F4AB for ; Wed, 26 Apr 2017 08:30:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2F4AB7F4AB Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2F4AB7F4AB Received: from calimero.vinschen.de (ovpn-116-117.ams2.redhat.com [10.36.116.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id F039882474 for ; Wed, 26 Apr 2017 08:30:58 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 3902DA8034D; Wed, 26 Apr 2017 10:30:58 +0200 (CEST) Date: Wed, 26 Apr 2017 08:31:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: newlib-2.5.0 bug report Message-ID: <20170426083058.GE12712@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="at6+YcpfzWZg/htY" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017/txt/msg00318.txt.bz2 --at6+YcpfzWZg/htY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 660 On Apr 25 18:03, David Binderman wrote: > Hello there, >=20 > newlib-2.5.0/newlib/libc/sys/linux/iconv/gconv_trans.c:196]: (warning) Ch= ar literal compared with pointer 'newp.fname'. Did you intend to dereferenc= e it? >=20 > Source code is >=20 > strcpy ((char *) newp->fname, runp->name); > while(newp->fname !=3D '\0') newp->fname++; >=20 > Maybe better code >=20 > strcpy ((char *) newp->fname, runp->name); > while(*(newp->fname) !=3D '\0') newp->fname++; >=20 > Regards >=20 > David Binderman Makes sense. Please send a patch. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --at6+YcpfzWZg/htY Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZAFrCAAoJEPU2Bp2uRE+gGzQP/3sPNgvrCOrq16IdE5FMf7gN 7osw7JQZqVro5ebKmRXEmuQO8CpTdqKWtfyf1p45tby/j6Ro+dSI0I5bItQy8GJq psh+uKgMvwWvcAJmhZ8fPv59aynJ+Yt8ZZkhkCDSTTjBbrXxVi8hRQ9bPcpave/F b6fjCSyrcrkCu3krxQ8ETKGyYg2tY3gkpUsr27i+N2szlE5hl8dFX5SKq5+0VW1Y Vw3pHjwI9z1nvsMMRoDXwqC5onmWHBkhWJh2IbzrE+yZFYmU0bm9FFTbwikB7Zob crHnmam520AxZJhXADdO3Y2DKNFF75rm8DsWMcEPNgSb0KPuUViWX1sOQ6epCggI 8LM0f2+V79xO1UOS0ONJaenKxEb+g51ELDgpDXzMVjOm4dV8PNBUS0m5FqBoNSRd dHDb/kOyTU8hjct+LmnZ7wDDp374y3k/Ka9LODo2n95wugtqJTz5VuTG+HNnq3V6 a8Zc0tbzGEHnRI+LeNNK1rZ/gBsr6ocaVGMu0uf52W9zfaeaEHSdETWqkQ6XJTpi 8ezEjq0jFDu0BLgWH/tobIhPsRiP4t+6/Tni3Fef2wDDXFE1AP47mVzpcWG4X79J /xoBM64CMfcRpPQ+Y0UDNG5uDOpxk0hx56UV9WQ05TRqCXmIxfw7YGkAP26CbM6a 1I5dELGrgs230D3O5GI7 =XPNH -----END PGP SIGNATURE----- --at6+YcpfzWZg/htY--