public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH, ARM] Fix minor issues in memchr NEON implementation
Date: Wed, 07 Jun 2017 10:16:00 -0000	[thread overview]
Message-ID: <20170607101650.GD18287@calimero.vinschen.de> (raw)
In-Reply-To: <20170602102256.eyeslc2gyznswpvl@e107464-lin.cambridge.arm.com>

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

On Jun  2 11:22, Prakhar Bahuguna wrote:
> The NEON-optimised implementation of memchr has a couple of minor issues - it
> does not mask off the higher bits of the input character, and it uses a signed
> comparison instead of unsigned within the smallstr loop. This patch addresses
> both of these issues.
> 
> ChangeLog:
> 
> 2017-06-02  Prakhar Bahuguna  <prakhar.bahuguna@arm.com>
> 
> 	* libc/machine/arm/memchr.S: Add and instruction to mask off all but
> 	the lowest byte.
> 	Change blt to blo.
> 
> Okay for master?

Yes, pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2017-06-07 10:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 10:23 Prakhar Bahuguna
2017-06-07 10:16 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607101650.GD18287@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).