From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18571 invoked by alias); 7 Jun 2017 13:11:06 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 16638 invoked by uid 89); 7 Jun 2017 13:11:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:857, H*c:application X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Jun 2017 13:11:04 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 85981C0587C4 for ; Wed, 7 Jun 2017 13:11:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85981C0587C4 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 85981C0587C4 Received: from calimero.vinschen.de (ovpn-117-161.ams2.redhat.com [10.36.117.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35EA27D517 for ; Wed, 7 Jun 2017 13:11:07 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id EC43EA8068F; Wed, 7 Jun 2017 15:11:05 +0200 (CEST) Date: Wed, 07 Jun 2017 13:11:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Fix RTEMS ioctl() declaration Message-ID: <20170607131105.GB15217@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20170607090821.14403-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZfOjI3PrQbgiZnxM" Content-Disposition: inline In-Reply-To: <20170607090821.14403-1-sebastian.huber@embedded-brains.de> User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017/txt/msg00394.txt.bz2 --ZfOjI3PrQbgiZnxM Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 838 On Jun 7 11:08, Sebastian Huber wrote: > Using uint32_t for ioctl_command_t does not work well on 64-bit targets. >=20 > Signed-off-by: Sebastian Huber > --- > newlib/libc/sys/rtems/include/sys/ioccom.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/newlib/libc/sys/rtems/include/sys/ioccom.h b/newlib/libc/sys= /rtems/include/sys/ioccom.h > index 9c5350d1e..2c0e9ee71 100644 > --- a/newlib/libc/sys/rtems/include/sys/ioccom.h > +++ b/newlib/libc/sys/rtems/include/sys/ioccom.h > @@ -36,7 +36,7 @@ > #include > #include >=20=20 > -typedef uint32_t ioctl_command_t; > +typedef unsigned long ioctl_command_t; Why do you need a ioctl_command_t at all? It's not in FreeBSD either. Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --ZfOjI3PrQbgiZnxM Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZN/tpAAoJEPU2Bp2uRE+gmHAP/jBHOpBA014wsBWVVj4uVtJE nPR92+64ScJsPGJeAbg6OnKbJwiaEwA45xqOiKFXp5uyWvVzsMf9UzX0iiJ/I61T hyOIy2UCNqYQN9ALAsTHjmDiraxkYlhXY6MlQwjmreVWwXU00XjXCpo6PYzMhVkh g3bX5bF8VoUEngUETZ/klDS5rnhXnxdO1DdPz9W7zbGWcpRXdkOD6H2rMYOe5lAG ZWvu1u1kxu5e3P4Kovw1l/4f6qJ7G4IN802fEHLsWeUDG8u9eZeOTX1gAlvgzYKu MTCpNZkHJE93pn0if7jVNT09/HCziV9WO7a1qe/TcH8kIoECM/7YWPOzJT9rjuhh kdAhf+9rjHnucGySkP6pZCAR8YNESg/xzjjrbmuqzbn8nCiJd0aKKXqoQWrD6MIs naYbeVJCdyl6Iuyk297huEbrLIOqvZFf2HZ1CFVqfGUTv/67YbSv6V9nf5lXds2L Z63sER2uM+4OloIccX6g6zxFSkpRVcBwPn/pqsuP2//G/GzAjBR8ar+Sl2l0ZLy3 KM5QTPEtH2RoZNA4rXFiMiUzdOk8bskHbrtsdTp/HtQbDVsxGJC0rPx7mWHnLY7H 9gIO3O7WUNrrlq2NCPsoujKjXxm0VGhrHHUYWt2EVKcUZ9HMCEMcK8zMiEjE9Brw sD/4/QOQ3tzZjoO7hLXF =/ZpC -----END PGP SIGNATURE----- --ZfOjI3PrQbgiZnxM--