From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33994 invoked by alias); 7 Jun 2017 14:27:35 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 31318 invoked by uid 89); 7 Jun 2017 14:27:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*i:sk:9b0bcdd, H*f:sk:9b0bcdd, H*c:application X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Jun 2017 14:27:33 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 425A17D4EF; Wed, 7 Jun 2017 14:27:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 425A17D4EF Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 425A17D4EF Received: from calimero.vinschen.de (ovpn-117-161.ams2.redhat.com [10.36.117.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 110E37DFDC; Wed, 7 Jun 2017 14:27:36 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C6B24A8068F; Wed, 7 Jun 2017 16:27:34 +0200 (CEST) Date: Wed, 07 Jun 2017 14:27:00 -0000 From: Corinna Vinschen To: Sebastian Huber Cc: newlib@sourceware.org Subject: Re: [PATCH] Fix RTEMS ioctl() declaration Message-ID: <20170607142734.GC19744@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Sebastian Huber , newlib@sourceware.org References: <20170607090821.14403-1-sebastian.huber@embedded-brains.de> <20170607131105.GB15217@calimero.vinschen.de> <9b0bcddf-1cf7-974c-8370-1cdf94c76274@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f0KYrhQ4vYSV2aJu" Content-Disposition: inline In-Reply-To: <9b0bcddf-1cf7-974c-8370-1cdf94c76274@embedded-brains.de> User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017/txt/msg00396.txt.bz2 --f0KYrhQ4vYSV2aJu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1287 On Jun 7 15:14, Sebastian Huber wrote: > On 07/06/17 15:11, Corinna Vinschen wrote: >=20 > > On Jun 7 11:08, Sebastian Huber wrote: > > > Using uint32_t for ioctl_command_t does not work well on 64-bit targe= ts. > > >=20 > > > Signed-off-by: Sebastian Huber > > > --- > > > newlib/libc/sys/rtems/include/sys/ioccom.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/newlib/libc/sys/rtems/include/sys/ioccom.h b/newlib/libc= /sys/rtems/include/sys/ioccom.h > > > index 9c5350d1e..2c0e9ee71 100644 > > > --- a/newlib/libc/sys/rtems/include/sys/ioccom.h > > > +++ b/newlib/libc/sys/rtems/include/sys/ioccom.h > > > @@ -36,7 +36,7 @@ > > > #include > > > #include > > > -typedef uint32_t ioctl_command_t; > > > +typedef unsigned long ioctl_command_t; > > Why do you need a ioctl_command_t at all? It's not in FreeBSD either. >=20 > Its used by the legacy network stack in RTEMS (e.g. various device driver= s). > I don't know who introduced this type and why. glibc has also simply > "unsigned long". Ok. At this point I would have replied "please apply", but you already did that. It's write *after* approval ;) Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --f0KYrhQ4vYSV2aJu Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZOA1WAAoJEPU2Bp2uRE+gQIkQAJKx7wquaZOb8ASuhllTHI7K EQrXrXs78yKqkCK4pgKEsO3MRO2B2pXMVOoPkGi8OxJYe6Rg2WGC196GA1E0C7Nk BJth7zBmyxxDo+NEsRU++pUUl1tPkAlvfSQeAZ7pkJrMnsbd8Tzq8CUY+/vYfzGm 4C2OprAJaFl9PT7LKMFvBrzphHouk8yEEHHTcP1LtU3pl8FuKhcUorZxJzjoAWrU wkvEv0bpX1nLkDZsMPDy6+KZL3Pv1HIIKh1jpf90TyhiHzHQJFRe2xOk6t4aMjZw rmxLX2/Ny20o/QCb65w/kUQVNmPlXjT60BBg6ccuoI6hfXScQ3CpfTE13AQi4Vee +rv05qBMC9qnZAuf7ubeQNvfFyeFsQkg5TynSDw6GQ3D2uDx+m5KASzGNiH2X95C 6LOQy5jZeAwHSICIVjNkGw+2DZ4R5lyUuxTkN8/deyzs6mpFZHhToZNseXJZwj2D 3IXK6SqojBC5sy9xQcraXBGKoc+VurJhQFe7VHj+8PgvkUOp91Dtquxyds4wa/j1 yLSxa/31Ne0CuwaQhlToLZwh/fio7rN2gBFRpylABggY7Yp9DqaCQCOW8hVY0+Tc JZ+KIackHWWdUrZ5gZovCaZ9cBX7Q2vtPgN79UEUXZytmrUBZEXdaY76opNhzfzL /2Hg/8n+LHg/7XFtkTdR =Nrl+ -----END PGP SIGNATURE----- --f0KYrhQ4vYSV2aJu--