From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48838 invoked by alias); 14 Jun 2017 08:44:07 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 47721 invoked by uid 89); 14 Jun 2017 08:44:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*i:sk:cc1fb03, H*f:sk:cc1fb03 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Jun 2017 08:44:04 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9410920B1A for ; Wed, 14 Jun 2017 08:44:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9410920B1A Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9410920B1A Received: from calimero.vinschen.de (ovpn-117-161.ams2.redhat.com [10.36.117.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B0A0777F1 for ; Wed, 14 Jun 2017 08:44:07 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 19B58A80706; Wed, 14 Jun 2017 10:44:06 +0200 (CEST) Date: Wed, 14 Jun 2017 08:44:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: Adding Methods related to inttypes.h Message-ID: <20170614084406.GP13513@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wZdghQXYJzyo6AGC" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017/txt/msg00414.txt.bz2 --wZdghQXYJzyo6AGC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1472 On Jun 14 07:42, Sebastian Huber wrote: > On 13/06/17 21:03, aditya upadhyay wrote: >=20 > > Hello Developers, > >=20 > > I have ported the methods what are declared inside the inttypes.h > > header file from freebsd. I am requesting you to please review the > > code. > >=20 > > I am not able to push the code of ccoshl.c in my forked repo. It is > > saying fatal error. I do not know how to apply the signature.asc file. > > Please have a look on my issue. > > [...] > > newlib/libc/Makefile.am | 4 +- > > newlib/libc/inttypes/Makefile.am | 24 +++++++ > > newlib/libc/inttypes/imaxabs.c | 44 ++++++++++++ > > newlib/libc/inttypes/imaxdiv.c | 53 ++++++++++++++ > > newlib/libc/inttypes/strtoimax.c | 144 ++++++++++++++++++++++++++++++= +++++++ > > newlib/libc/inttypes/strtoumax.c | 135 ++++++++++++++++++++++++++++++= ++++ > > newlib/libc/inttypes/wcstoimax.c | 151 ++++++++++++++++++++++++++++++= +++++++++ > > newlib/libc/inttypes/wcstoumax.c | 144 ++++++++++++++++++++++++++++++= +++++++ >=20 > These functions should probably go into "newlib/libc/stdlib" just like on > FreeBSD and NetBSD. Where does this "inttypes" directory come from? ACK. Also, newlib already has functions strtoll, strtoull, wcstoll, wcstoull. So the aliasing to strtoimax, etc, seems like a bad idea. In theory, all we need is an aliasing from strtoll to strtoumax, etc, in the existing sources. Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --wZdghQXYJzyo6AGC Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZQPdVAAoJEPU2Bp2uRE+goZQP/1pddWZxNxEp5TRZUM3an4+e RABNLSktkJfWTQReE+4SrA6pMaOKNWy43UwRbIp/XsEgfFt/aZoPX4HnC61JEDcF XjkQ2pBLenbmEmjKSObahk2t4STW3TqhjZ1M9Jbf+NbIFM03CniB3Dte8Q4LB0qT wxpce2aDeJ3Oj9xZUR4ODyrTXSKzq701dzO1Pqgf/S0rWlNfXF4bE0lfe/RGz8MC iJ+CODXKm5JYjUcARZtAfSFquVwCqSfBHyeELiqE3GoRpMJaAWnn+gW0adK2huSh 4MqI4fK95YbnhMomgyMDs9boH0k/CIYmKXq0J9IYug2hz+0IV6CZOP7Uqx9et3zN W9HZWriWwl8tA4GNz1zxOfpNYbeW8lI+VvMqyFFCtXUpF37dBAot33LlDfxKUUHX xrZCrgbrkEPmi+Z23PR1MpPVDoJ/F0cDWOVwc37kTNwZlMmPdieaT+bSoEY2zrNa 8dbcyiEuB80GDsQ3cmlRAtofVwB85odudTQqOchmhju2ssGVj2/FaW0Cq8jUvACN 6NiH15rz8/aB4ifzz2fyZ25YZj6+9+cd2akUFUhA//NctD8+f3zlTF+OYaoVd6Nu mjwzwcJH7O43ADHXYw1zI8jXn0SKceTvhCqDycn5og9yDV3237pRMXPq/oqKD7ed pCoF2rt4QpQpPYgzFu7h =bbGp -----END PGP SIGNATURE----- --wZdghQXYJzyo6AGC--