From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57451 invoked by alias); 21 Jun 2017 08:28:29 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 56689 invoked by uid 89); 21 Jun 2017 08:28:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*i:sk:0205aa5, Newlib, H*f:sk:kqQRxUp, H*f:sk:0205aa5 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 08:28:28 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C78767EBD6 for ; Wed, 21 Jun 2017 08:28:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C78767EBD6 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C78767EBD6 Received: from calimero.vinschen.de (ovpn-117-36.ams2.redhat.com [10.36.117.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 93FD06BF62 for ; Wed, 21 Jun 2017 08:28:26 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id D2833A80703; Wed, 21 Jun 2017 10:28:25 +0200 (CEST) Date: Wed, 21 Jun 2017 08:28:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: Importing cacoshl.c and its dependent methos, Message-ID: <20170621082825.GD6658@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <0205aa55-7b80-245d-0af6-4fe67c15429f@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E13BgyNx05feLLmH" Content-Disposition: inline In-Reply-To: <0205aa55-7b80-245d-0af6-4fe67c15429f@embedded-brains.de> User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017/txt/msg00445.txt.bz2 --E13BgyNx05feLLmH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 978 On Jun 21 08:46, Sebastian Huber wrote: > On 21/06/17 04:24, aditya upadhyay wrote: >=20 > > Hello Developers, > > In cacoshl.c, There is a dependency between cacoshl.c and csqrtl.c. > > In ported csqrtl.c from NetBSD, stdbool.h is there, But i saw there > > is no stdbool.h. > >=20 > > So for bool data type, I have used enum. Is it a right way or not. > > please suggest or do i have to use stdbool.h from gcc library ? >=20 > is currently not used by Newlib. I am not sure if we should a= dd > this dependency if its only needed by csqrtl.c (in overall NetBSD libm) a= nd > not visible to the user. >=20 > I would replace the #include with >=20 > #ifndef __cplusplus > typedef enum { false, true } bool; > #endif >=20 > and keep the rest of the code unchanged. Wait. Isn't stdbool.h available in gcc for ages? When building newlib, shouldn't we be able to rely on c99 being available? Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --E13BgyNx05feLLmH Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZSi4pAAoJEPU2Bp2uRE+gAncP/RRlgXG9J7cHNqzV4sxHn6/R WlA/qtxqjuKR36QDUA8UfLdBf8IsIFT80fxLOJIZ+Xwyk7GqeV3xUkmI4tJ3qANw elFQrKGOuvnmkJbxJrnmWD+Crn7Qcc63yxIF61opGPm334+vNkiu2vJ6XXV1hY0T P9gF3caL6kFsWFer9tbQLin8w1kJaZAyo8J2HA8K4yBpj1t1Xv/tE+ba4RSflte+ hSaJpmYepWe/GnlWaIZvru0AJyCoufjw3eHgTAofXRLJ0Z2ysEcEhNSiUiuwwObU WYOiz6VU6egduKLjqpkbvKia3YdBQOxsnADUoiA9KYq1uezrCn9Jf4xono+1DGQl ZIVsDFXZPRBmfLaEj6TaMkQk/VTvkn2bEDzW4N7PL4N+5mGVI5I8/C84gI2aF73p lvxEU1du9oh7cxoJ1mZKNUc9RAvZ49jmTkF/bC31dWaOQ5+E1hbIJSB35ZI4Djv4 f4bPPYcpPqE1MeKEeMrqGPdaUQaWgq/mqbSG08jt3oleu7ln94JtIUDsgnBmZq3K nByBgMGOgr+sjdiDKVmPOS1t8zGspaDnlIN40jXwXFVG8q2960h0ThIHigRydPbl JVywP154nJUeK6jOl6oaI2ZcERcjfh/uzqHcQI10G56MGbgz+B4zv2hc1lskhStz 4INb9sBuyQt4fl6Mpipt =GsBJ -----END PGP SIGNATURE----- --E13BgyNx05feLLmH--