From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115191 invoked by alias); 26 Jun 2017 08:22:15 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 115150 invoked by uid 89); 26 Jun 2017 08:22:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:961, __SNBF, __inline, H*f:sk:0ae11f4 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Jun 2017 08:22:11 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F0DF81240 for ; Mon, 26 Jun 2017 08:22:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0F0DF81240 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0F0DF81240 Received: from calimero.vinschen.de (ovpn-117-36.ams2.redhat.com [10.36.117.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id BAA4871CAA for ; Mon, 26 Jun 2017 08:22:09 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 05F81A805F0; Mon, 26 Jun 2017 10:22:09 +0200 (CEST) Date: Mon, 26 Jun 2017 08:22:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 2/3] Add stdin_init(), stdout_init() and stderr_init() Message-ID: <20170626082208.GA6201@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20170623092259.29325-1-sebastian.huber@embedded-brains.de> <20170623092259.29325-2-sebastian.huber@embedded-brains.de> <20170623140231.GE18863@calimero.vinschen.de> <0ae11f4a-ddbb-c74e-bdc5-f80d259d4733@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017/txt/msg00476.txt.bz2 --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 923 On Jun 26 08:17, Sebastian Huber wrote: > On 26/06/17 08:15, Sebastian Huber wrote: >=20 > > On 23/06/17 16:02, Corinna Vinschen wrote: > >=20 > > > > +static void > > > > +stderr_init(FILE *ptr) > > > > +{ > > > > + /* POSIX requires stderr to be opened for reading and writing, e= ven > > > > + when the underlying fd 2 is write-only. */ > > > > + std (ptr, __SRW | __SNBF, 2); > > > > +} > > > > . + > > > Perhaps these func should be inline? > >=20 > > Ok, I change them to "static __inline void". >=20 > Or simply "static inline void"? Is it time to assume at least a C99 compi= ler > for the Newlib sources? We're already using inline in the local arc4random header and in a couple of target dependent files. I guess we can safely assume a C99 compiler should be used for building newlib itself. That doesn't hold for exported headers, of course. Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZUMQwAAoJEPU2Bp2uRE+gITcP/RPxet5VyYCz0H3idftzbjRM 40v6chSWTkNpE1cZ9QP+LtA77ZLnq/FC15I4o6uSOdtOQz3D3d2wqsR4ij61ROKf j2YKi4rqKZ/ouNjEXNK/o1aWBgg2J3jhbh+cXRbiB4mrSItZXRxYOakYbwwm/fdm 5Jo7kKlbIR55U1SaJazyWQ+KjeQP2G/tlC4eT9/oqJdOOIWeahMkibyBGoTy4pjc iEf4+zreeM+fu3B2YTTlRolqAEM9sJO6HLz4A+VHef7rnnUkp2jtZeggxuJLRTYd aJEK6Q74lYSLhY+pSvS7Gy2gIRLEasf3KX0VQ0T//WTWAkQFjPQWQn09bFx+BuwR /f9+TPnxG1GVZf0D/JFK0UzgRdLcfGi07GPv6z/gDNAYdR90HBmdV2yICyWjE/HC QIFgYjJrscja3KWIhQNmYqP2A4WE5IY/SB3tabTgkNzEAZ9DqPpp1rcZiybzVOpY sHvD2lCeEUZv8RD/FZq+Ozwk1cS5bmfEPXEUH8I1yUAUrtv1bCw5HLu6Ne5zW8DH F4U4AuUtgbcc2Wt25M/9um3uYqp8GMUbhVwmTCXOcj1BQ+baQYiD0wejwgKJp9f1 1beNLx1qeea6rjDWDIKwDzzyzWeUK1HAb6G3Q1AcCxSo/MEB8hGnnIavts/xq9E5 37bdjaAFV+RHJIu6qas5 =rdTN -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--