From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: Importing cacoshl.c and its dependent methods from NetBSD
Date: Mon, 26 Jun 2017 08:26:00 -0000 [thread overview]
Message-ID: <20170626082611.GC6201@calimero.vinschen.de> (raw)
In-Reply-To: <CAMZxAxfwT=4t9Jvsi0gAiCM93vPp3qRcJtEr1DRm8CDLvNFWLQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
Hi Aditya,
On Jun 23 19:28, Aditya Upadhyay wrote:
> Hello Developers,
>
> I have modified the csqrtl.c and including stdbool.h. I am requesting
> you to please review the patch for cacoshl.c and suggest me needed
> modification.
Your complex math changes are not independent of each other due to the
required changes in complex/Makefile.*.
Would you mind to recreate the patches as a git patch series to enforce
a clear order? That also allows you to do the Makefile.* patch only
once, as last patch of the series (just a suggestion).
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-06-26 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 13:58 Aditya Upadhyay
2017-06-26 8:26 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626082611.GC6201@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).