public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: Adding cephes_subrl.c in newlib
Date: Mon, 26 Jun 2017 08:29:00 -0000	[thread overview]
Message-ID: <20170626082928.GD6201@calimero.vinschen.de> (raw)
In-Reply-To: <CAMZxAxewEwktYqgKgU8U2MkhBod7PAhO_DGqP+u8KAwpBHm+ag@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

On Jun 24 00:26, Aditya Upadhyay wrote:
> Hello Developers,
> 
> I have ported cephes_subrl.c from NetBSD. Please review the same and
> suggest me any needed modification.
> 
> Thanks & Regards,
> Aditya Upadhyay

> From 9c93115007bcc4b823716c09176e149ccb2227b7 Mon Sep 17 00:00:00 2001
> From: Aditya Upadhyay <aadit0402@gmail.com>
> Date: Sat, 24 Jun 2017 00:23:47 +0530
> Subject: [PATCH] Adding cephes_subrl.c in newlib.
> 
> ---
>  newlib/libm/complex/Makefile.am    |   4 +-
>  newlib/libm/complex/Makefile.in    |  14 ++--
>  newlib/libm/complex/cephes_subrl.c | 128 +++++++++++++++++++++++++++++++++++++

Where's cephes_subrl.h?  You use it, but your patch doesn't provide it.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2017-06-26  8:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 18:56 Aditya Upadhyay
2017-06-23 19:06 ` Joel Sherrill
2017-06-26  8:29 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170626082928.GD6201@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).