From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124249 invoked by alias); 5 Jul 2017 11:26:14 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 124232 invoked by uid 89); 5 Jul 2017 11:26:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Jul 2017 11:26:12 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5FFF3345B7; Wed, 5 Jul 2017 11:26:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D5FFF3345B7 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D5FFF3345B7 Received: from calimero.vinschen.de (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2737600CC; Wed, 5 Jul 2017 11:26:10 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id E34DCA805B7; Wed, 5 Jul 2017 13:26:09 +0200 (CEST) Date: Wed, 05 Jul 2017 11:26:00 -0000 From: Corinna Vinschen To: Sebastian Huber Cc: newlib@sourceware.org Subject: Re: [PATCH v2 3/3] Add ffsl(), ffsll(), fls(), flsl(), flsll() Message-ID: <20170705112609.GD30902@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Sebastian Huber , newlib@sourceware.org References: <20170704133435.9840-3-sebastian.huber@embedded-brains.de> <20170705085414.12755-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WChQLJJJfbwij+9x" Content-Disposition: inline In-Reply-To: <20170705085414.12755-1-sebastian.huber@embedded-brains.de> User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017/txt/msg00560.txt.bz2 --WChQLJJJfbwij+9x Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1294 On Jul 5 10:54, Sebastian Huber wrote: > Use compiler builtin for ffs(). Remove duplicate implementation from > Cygwin. >=20 > Signed-off-by: Sebastian Huber > --- > newlib/libc/misc/ffs.c | 14 ++------- > newlib/libc/string/Makefile.am | 5 ++++ > newlib/libc/string/Makefile.in | 64 +++++++++++++++++++++++++++++++++---= ------ > newlib/libc/string/ffsl.c | 34 ++++++++++++++++++++++ > newlib/libc/string/ffsll.c | 34 ++++++++++++++++++++++ > newlib/libc/string/fls.c | 38 +++++++++++++++++++++++++ > newlib/libc/string/flsl.c | 38 +++++++++++++++++++++++++ > newlib/libc/string/flsll.c | 38 +++++++++++++++++++++++++ > winsup/cygwin/syscalls.cc | 22 --------------- > 9 files changed, 240 insertions(+), 47 deletions(-) > create mode 100644 newlib/libc/string/ffsl.c > create mode 100644 newlib/libc/string/ffsll.c > create mode 100644 newlib/libc/string/fls.c > create mode 100644 newlib/libc/string/flsl.c > create mode 100644 newlib/libc/string/flsll.c Patchset looks good, please push. For Cygwin we also need to add the new fls* entry points to common.din and to the docs. I'll do that later, when you=20 pushed your patch. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --WChQLJJJfbwij+9x Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZXMzRAAoJEPU2Bp2uRE+gQfYP/RBEIcvEpz8l9coQVriHIqoa /60YVy+v+uLW7oBW4hTRbOLMFR7mkiR5ntDB0nYmwqdMmgGgBNRwUjrG/xfC9FJR Smr2LgkMn5FqCzml0fji0ZehtLqoFxIf3xjyxXpYaaY5Fju6NFt1jmR0OyEDRwY+ lksfqmeG5AVKAJWKNgz2F9fnwK1eHxFcQ5NC3NqQhXlrEUtStAmkzSY2XlDefOu5 fYdDS4SqsEjkTThJg/Aow56M7nR4YMY7moQ+9xg+kLBQgavOPHohAJu42PtErfh9 wxVTN6FGME4oARJIYHkR4M2UMQt2MkO2Fd9kZz/H0eh/WnJlxH25173JjC4pWTVS 98n65nJxwovN0H4g0lV9gDZ7Nqrm1vUrqsJ1bXzIs3d63OHxIEgPM/iNVsrqwjE/ 5wuvEqh5ZRptC7zNX8BFa84qQMSUUoTKF3p3ahZyvyi0Sw4gcLmO3R1bLOrHrB+v 7nzK++1bfFiYge54M0pKyWJBLK1VzdeLANpapnsK7GEVQ+Td+Tf1fO1l+dkeuk1B vzO6+O5uWVQ49IUCXQyYyU1xHEE3sfjDTJ8vt+FISnnpu0jbJnJDTRiW5hCxxZ0v I5HyZh9Eujm53wVG7BWtjpV7htx5mNOhm4saTN8zwNUzrz+xoIv9HEIzQ0ES/anx xEH866L/GCaptiWnG/fC =B6IE -----END PGP SIGNATURE----- --WChQLJJJfbwij+9x--