From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63610 invoked by alias); 20 Jul 2017 14:37:53 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 63442 invoked by uid 89); 20 Jul 2017 14:37:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Jul 2017 14:37:45 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 49C864A6EF; Thu, 20 Jul 2017 14:37:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 49C864A6EF Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 49C864A6EF Received: from calimero.vinschen.de (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id E6E7F80A44; Thu, 20 Jul 2017 14:37:43 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 7EEABA806EF; Thu, 20 Jul 2017 16:37:42 +0200 (CEST) Date: Thu, 20 Jul 2017 14:37:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Cc: Joel Sherrill Subject: Re: Importing inttypes methods from FreeBSD Message-ID: <20170720143742.GA20229@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org, Joel Sherrill References: <20170719122806.GA6325@calimero.vinschen.de> <20170719154430.GB6325@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SW-Source: 2017/txt/msg00611.txt.bz2 --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2056 Aditya, On Jul 20 13:54, Aditya Upadhyay wrote: > Hello All, >=20 > This is the modified patches for inttypes methods. Now I want to make > testsuite for these methods in newlib, but i have no idea how to make > test in newlib. Can anyone please help me for the same or point me > some link. Please review the patch. Sorry to say that, but this is unusable. I can't apply the below patches because they are missing the original patches. On the other hand you're using the original subjects, as if the below patches are the entire thing. They aren't. The below patches are only relative patches to the ones you orignally sent, but which, of course, haven't been applied yet.=20=20 Please, make yourself familiar with `git rebase -i'. Go back to the original patches actually adding the files imaxabs.c, etc., and squash the below patches into the original patches. Then send the resulting, *complete* patches as a patchset. Every addition like imaxabs.c should be a single patch in the patchset. > diff --git a/newlib/libc/stdlib/Makefile.am b/newlib/libc/stdlib/Makefile= .am > index 6cca5f005..d97b0250c 100644 > --- a/newlib/libc/stdlib/Makefile.am > +++ b/newlib/libc/stdlib/Makefile.am > @@ -34,7 +34,6 @@ GENERAL_SOURCES =3D \ > getenv_r.c \ > itoa.c \ > imaxabs.c \ > - imaxdiv.c \ > labs.c \ > ldiv.c \ > ldtoa.c \ > @@ -59,7 +58,6 @@ GENERAL_SOURCES =3D \ > sb_charsets.c \ > strtod.c \ > strtodg.c \ > - strtoimax.c \ > strtol.c \ > strtorx.c \ > strtoul.c \ > @@ -70,8 +68,8 @@ GENERAL_SOURCES =3D \ > wcstombs.c \ > wcstombs_r.c \ > wctomb.c \ > - wctomb_r.c > - > + wctomb_r.c \ > +=09 ^^^^^^^^^^^^ ...and don't add gratuitious white spaces, please. Joel, please take an interest in Aditya's work in the first place. *You* were the one who gave these tasks to Aditya, so *you* should be the one guiding him and reviewing these patches, not me. For any followup patches, I will not look into them unless you gave your OK first. Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZcMA2AAoJEPU2Bp2uRE+giCgP/j7IE+DvAzdW7tWsaQvRxAP4 LiGMItDyv3JxdpL26IOgO4zAVUPMnQIH8EX+tHM408ngkKvpwGjg2L9c1im9umw3 VIrF2bvgMNxtfqG95uwTi6hlvK4rMszH0VKnQOplL1TohndzjrSFVWWm0cfvtozB I+xpO3qot8yp9HkTQsYBoUhJM8WpiSAyR4jp7mVJNJ6vPyuEgTkx0VdFppslFLyj 0u8qJwm2OSrVewd+KXC6HuJ56uJloyLZ1XBXGl3PxsvBVf1eNJjw2OX4TNhW2PdY DDvSCqyPHxQTFeCaT3Yl/8ULWaj/stQsyMaJ8uIPsJ4o/3uNhYz4IEpicKQVppSK /fvW1G9iFfHmdl/yCFq97SuANWzi05zL/S/Qm6Q+StV04q6NwIhlaDqcXyzuXVoB Fq8+y8vd+FoYz4dOBcIOrIQPg+/z6+XgcjcAgVTNR1YVVbd22ZjZlyl9DE/GwvDN kxz53VJalhoN7CeoYYvUPb2o3yY4KT29xOnYEexhM5nOtdstXjjSaEBRuAsr7Yk4 y3gfmq9FxyfvXJunyUeHoQLfMD8ROExnutsAqK6hmPG8IgtMFb/+5wEBv5As2U/p ZYm6p5HBGCaQwUKn0+a1r6Vp3Jpa1IMcX+6h6aTqY6XiPCg4/R3KxpZEVoVT3wp3 rj7l09R5BW9Pe6ddhERg =7Obx -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--