From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64482 invoked by alias); 28 Jul 2017 10:43:08 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 64202 invoked by uid 89); 28 Jul 2017 10:43:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=apologize, H*c:application, learning X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jul 2017 10:43:07 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B3E5BA1F70 for ; Fri, 28 Jul 2017 10:43:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B3E5BA1F70 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vinschen@redhat.com Received: from calimero.vinschen.de (ovpn-117-128.ams2.redhat.com [10.36.117.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D2835D747 for ; Fri, 28 Jul 2017 10:43:05 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id BE6D2A805A0; Fri, 28 Jul 2017 12:43:04 +0200 (CEST) Date: Fri, 28 Jul 2017 10:43:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: Importing inttypes methods Message-ID: <20170728104304.GA24013@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20170726110849.GG14419@calimero.vinschen.de> <20170727123207.GB27695@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SW-Source: 2017/txt/msg00683.txt.bz2 --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1244 On Jul 27 19:30, Aditya Upadhyay wrote: > Hi, >=20 > I apologize for the inconvenience caused. Actually i am new to git and > still learning commands. I am trying my best and want to assure you > that i will be familiar with the git soon. I will try not to repeat > the same mistakes again in future. > I am attaching the fresh new patches for last 4 methods with all > possible changes. I am requesting you to please review the patches. Patches are fine and what we talked about, but I realized belatedly that we have a problem with the inttypes.h header file: Your patch includes xlocale.h only if __POSIX_VISIBLE >=3D 200809. However, you declare the _l functions unconditionally. This will break builds which don't define _POSIX_SOURCE to the right value. Additionally, these functions are BSD-only at the moment. They are neither in glibc nor in POSIX. So, what we should do here is this: * Include xlocale.h only if __BSD_VISIBLE. * Declare the _l functions only if __BSD_VISIBLE, too. It's your choice now: Do you want to recreate the below patches accordingly, or shall I aplly the patches as they are, and you create a followup patch just fixing inttypes.h? Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZexU4AAoJEPU2Bp2uRE+gxF0P/2hXB6eU8bimMeeACAWY/eZZ vBPs77fD1C7RQVHLriJYXYilk2xLVR5RyCmfkoCu1vVFpPhX/ohzD3LjW+IxD+Dk n+KCMIfo2XQakXuwqhQcB4AyUWDLEQ0tjvxUXWBqolQTvfDtYPKRz5Pzc8pmKWBj CnP2iAjSd1PPYpiX7F5LyMO31HiZDWjFAftUzxsrqVkxLDLi9VYN3QVYzd72itfF bGN/E/wbZneFaugdCsuf8haVHJpIDECaFHMyomowiicfesi4jq+/uGrzRBPaO5lr alIzwl8tY9l3EGMAeMI0dWPJSSzgWjO36OhYMDwxSc5Q96Z1nSspYLJ4xS39eSrI JlI0YUsEcjxeT29gWhuPObcliyHzyhKIhJ0DldJ9gLzsW3uxz7feRvSFAlCbISLn a4G2Atsp9m4fjDUv6n2cxdmRDyNMm3vrhDhuAt3PuRR4fbAOhT7Pvak3S+ckjwPT Uz9QBZ76lLiBipIUwpBbBxEH+Vf437g6zKGfqdh8Zvvnb/bqyvPcWKlVmADnB3yN XdKfcYN3+RgZlXyPDXqHEJQVgCq0eQYg+CdKgSc5erPZ74mEWUDTFuaVArpPxLUz vIruzJr2oNuAXAAz3N5nnZ2TUQkG4oIBmuKDr9rRQj6yoL11JEz+pOMrGj9Xy515 GlpqN6IeAFvlgBRHH3sJ =kubQ -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--