From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125182 invoked by alias); 28 Jul 2017 13:08:09 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 124788 invoked by uid 89); 28 Jul 2017 13:08:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:CAC82fA, H*i:sk:CAC82fA, apologize X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jul 2017 13:08:06 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E5E19F40E0 for ; Fri, 28 Jul 2017 13:08:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E5E19F40E0 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vinschen@redhat.com Received: from calimero.vinschen.de (ovpn-117-128.ams2.redhat.com [10.36.117.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B5927767A for ; Fri, 28 Jul 2017 13:08:04 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id CEDFBA8063E; Fri, 28 Jul 2017 15:08:03 +0200 (CEST) Date: Fri, 28 Jul 2017 13:08:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: Importing inttypes methods Message-ID: <20170728130803.GD24013@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20170726110849.GG14419@calimero.vinschen.de> <20170727123207.GB27695@calimero.vinschen.de> <20170728104304.GA24013@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6WlEvdN9Dv0WHSBl" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SW-Source: 2017/txt/msg00687.txt.bz2 --6WlEvdN9Dv0WHSBl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2129 On Jul 28 07:40, Gedare Bloom wrote: > On Fri, Jul 28, 2017 at 7:02 AM, Aditya Upadhyay wr= ote: > > Just give a little time. I am creating a new patch set that fix the > > BSD_VISIBLE problem. > > > > Thanks, > > Aditya > > > > > > On Fri, Jul 28, 2017 at 4:13 PM, Corinna Vinschen = wrote: > >> On Jul 27 19:30, Aditya Upadhyay wrote: > >>> Hi, > >>> > >>> I apologize for the inconvenience caused. Actually i am new to git and > >>> still learning commands. I am trying my best and want to assure you > >>> that i will be familiar with the git soon. I will try not to repeat > >>> the same mistakes again in future. > >>> I am attaching the fresh new patches for last 4 methods with all > >>> possible changes. I am requesting you to please review the patches. > >> > >> Patches are fine and what we talked about, but I realized belatedly > >> that we have a problem with the inttypes.h header file: > >> > >> Your patch includes xlocale.h only if __POSIX_VISIBLE >=3D 200809. > >> However, you declare the _l functions unconditionally. This will > >> break builds which don't define _POSIX_SOURCE to the right value. > >> > >> Additionally, these functions are BSD-only at the moment. They are > >> neither in glibc nor in POSIX. > >> > >> So, what we should do here is this: > >> > >> * Include xlocale.h only if __BSD_VISIBLE. > >> * Declare the _l functions only if __BSD_VISIBLE, too. > >> > >> It's your choice now: Do you want to recreate the below patches > >> accordingly, or shall I aplly the patches as they are, and you create > >> a followup patch just fixing inttypes.h? > >> > Corinna, good catch. I mentioned this issue to Joel but it dropped out > the bottom some how. Is it only (for example) the strtoimax_l() that > needs to be guarded, or also the _strtoimax_l? (I suspect only the > strtoimax_l, but want to be clear before the next round of patches > lands here.) The reentrant prototypes use locale_t, so they depend on including xlocale.h, too. It's a bit uncommon but the simplest solution. Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --6WlEvdN9Dv0WHSBl Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZezczAAoJEPU2Bp2uRE+g53EQAKMuZWTZx7NqA3NeD0V2je+X //15Q4bbT5pF+o7wK1fpEYt2aht2+Y22Lh7i1f7kFB7pOEX9/quCx04/Tremw8iO 6IZqIcsuEbmEGED+YEBA7Vud+azoV4aDuykvtszUH7m2DlJE+qy4YbxAcc3/GQo3 lk5n3GPtPyNjRGfz18xZOOlXG2B5TgjxjN1jh1WH2/7w4JsYsWCUdKjjjlejosrm nIcmt0GZ3g9SfPSwxGkpaA+vSvslgoPa8LyHXPXICcmDz22B3KmRbjQtWvVzo8pR A/Yy7lnRSuYKZpmhTXh0tnKSBO7l/1Y5IpsQ0mh5fRRQQli9yJ0CDJcYHNzoXT/U +PobCCEtoVBuRSycuxH4FSzedMU0W5ZxteZ2b0SRckPW4mkBbnfVTjrwufH/thrT Ww467xL1w4SUbiTEtkhfNBmC+PgVJwwtl05Zdsdzd/jAYGmjY5AJj8o5IFOIcrYU LKPXwvznc1vs/fp2LEYXQcjhaxUhTKsgaDPtAaeUcF6kELqgCQgfUHDdegU5fyg/ o06ShxvTB3BVQIQwEalWXs8R7wYKSEU8WCX0+f0VdErm+lDKo0R3YQASG6/9eCbQ 54a2YpfiKKEteKTi0QeutNplj6+QFx70LeDPoy1SmOqw78kXUaxyWgq3N4pEq6mx i8lYsbBTMW6OOqIhYwW8 =cpYY -----END PGP SIGNATURE----- --6WlEvdN9Dv0WHSBl--