From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23784 invoked by alias); 11 Aug 2017 08:24:54 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 22235 invoked by uid 89); 11 Aug 2017 08:24:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=regen, Basically, fuzzy X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Aug 2017 08:24:28 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3024C5D5D4 for ; Fri, 11 Aug 2017 08:24:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3024C5D5D4 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vinschen@redhat.com Received: from calimero.vinschen.de (ovpn-117-128.ams2.redhat.com [10.36.117.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEFAA60461 for ; Fri, 11 Aug 2017 08:24:19 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 2130CA80970; Fri, 11 Aug 2017 10:24:19 +0200 (CEST) Date: Fri, 11 Aug 2017 08:24:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 1/4] Importing strtoimax inttypes method from FreeBSD. Message-ID: <20170811082419.GM3195@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <1501643979-32662-1-git-send-email-aadit0402@gmail.com> <20170802110435.GH25551@calimero.vinschen.de> <9df019b2-7915-8f72-17bf-8c85bf7b835c@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SLfjTIIQuAzj8yil" Content-Disposition: inline In-Reply-To: <9df019b2-7915-8f72-17bf-8c85bf7b835c@embedded-brains.de> User-Agent: Mutt/1.8.3 (2017-05-23) X-SW-Source: 2017/txt/msg00768.txt.bz2 --SLfjTIIQuAzj8yil Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2883 On Aug 11 08:32, Sebastian Huber wrote: > On 02/08/17 13:04, Corinna Vinschen wrote: >=20 > > On Aug 2 08:49, Aditya Upadhyay wrote: > > > --- > > > newlib/libc/include/inttypes.h | 12 +++ > > > newlib/libc/stdlib/Makefile.am | 1 + > > > newlib/libc/stdlib/strtoimax.c | 167 ++++++++++++++++++++++++++++++= +++++++++++ > > All 4 patches applied. > >=20 > > I made a few minor formatting changes in terms of whitespaces and > > missing empty lines between functions. Please compare what I commited > > with your local patch to see the differences. >=20 > The files are not built currently. We have to regenerate the Makefile.in.= I > had problems with that using automake 1.12.2: >=20 > configure.in:251: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detec= ted > in body > ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from... > ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from... > ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from... > ../libtool.m4:1080: _LT_SYS_MODULE_PATH_AIX is expanded from... > ../libtool.m4:4213: _LT_LINKER_SHLIBS is expanded from... > ../libtool.m4:5341: _LT_LANG_C_CONFIG is expanded from... > ../libtool.m4:141: _LT_SETUP is expanded from... > ../libtool.m4:67: LT_INIT is expanded from... > ../libtool.m4:106: AM_PROG_LIBTOOL is expanded from... > configure.in:251: the top level > configure.in:251: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detec= ted > in body > ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from... > ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from... > ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from... > ../libtool.m4:4213: _LT_LINKER_SHLIBS is expanded from... > ../libtool.m4:5341: _LT_LANG_C_CONFIG is expanded from... > ../libtool.m4:141: _LT_SETUP is expanded from... > ../libtool.m4:67: LT_INIT is expanded from... > ../libtool.m4:106: AM_PROG_LIBTOOL is expanded from... > configure.in:251: the top level > configure.in:241: error: version mismatch. This is Automake 1.12.2, > configure.in:241: but the definition used by this AM_INIT_AUTOMAKE > configure.in:241: comes from Automake 1.11.6. You should recreate > configure.in:241: aclocal.m4 with aclocal and run automake again. I just regenerated stdlib/Makefile.in (and screwed up the log message). > I don't know how to regenerate libc/stdio/Makefile.in using automake 1.12= .2. I'm always a bit fuzzy about this as well. Basically I cd into either newlib/libc or newlib/libm, whatever needs a regen, then aclocal-1.12.2 -I. -I.. autoconf-2.69 automake-1.12.2 --cygnus --no-force This regenerates a lot of files unnecessarily, but they can be easily reset to the current state (git checkout --) and I only keep the Makefile.in which actually needed the regen. Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --SLfjTIIQuAzj8yil Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZjWmyAAoJEPU2Bp2uRE+g+kkP/Azh1lM/DBwjzbRGNl07Gx7N A1g36qFLgCPoBLTgY6nT1MjqyWjC+pG/ETF5N2mJjo5aZPghQxCFKff1b8RN2yuB +rYPoS1LaLqAxPm96RrM7h1kJ96pGDo2FrBh0jK9OCY7EC/7al7amXXjP6Axc5UM I739FQnLUpj3kU6QAsI2m2AzuljHNCa7wBZO+Q4x5FfM9M5Ewc/MddAUWkxiZJvx /UHKoJhKiNO/hEAIrZVMp1/L3hyUNxTB2re3c/DqC808FgeXSV557r8UyTJOVtQa kY0uAvg2r7ndPOJZIEk7PYutZIGXf2myKAHRcwD5RF30v3WxrT05bYzo1ZGR0A+e D76KDNPFw5P/IU4GAuEK+ULdYDDDCS5/uacOneO9kSpgo58EiN9M95zDd6Q1+r63 3ABuYLS6/iXxrrLWqxYnhpYY8nCfb/73GdoDp8KAawEUN84A9gK63b80Rjci7gUv onMiPlySquTcoS17rXcu5Awu6lEFrYQYRKp1TQZPg1Pcn8DcB/M6oOfGUWe/AJ+L A9285gHO11l1NZDJVffD3YNdX8OQJUG90aEfF+rgzePjELhFfW/7b05S6xMo3KFg hHGbPaAaFJjw56LXibr1KV3dVjCMvXceJYdVZq+o3RMEoP1na+CJGqcUmcKp0esk +JnbKkvDNRocToOxSqjc =kdWE -----END PGP SIGNATURE----- --SLfjTIIQuAzj8yil--