From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83132 invoked by alias); 21 Aug 2017 09:01:49 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 82892 invoked by uid 89); 21 Aug 2017 09:01:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=doh, H*R:D*sourceware.org, H*f:sk:09a4309, UD:strptime.cc X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Aug 2017 09:01:30 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 90660285C8; Mon, 21 Aug 2017 09:01:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 90660285C8 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vinschen@redhat.com Received: from calimero.vinschen.de (ovpn-117-112.ams2.redhat.com [10.36.117.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 115F2600C8; Mon, 21 Aug 2017 09:01:26 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id BE78EA80422; Mon, 21 Aug 2017 11:01:24 +0200 (CEST) Date: Mon, 21 Aug 2017 09:10:00 -0000 From: Corinna Vinschen To: Brian Inglis Cc: newlib@sourceware.org Subject: Re: Cygwin strptime() is missing "%s" which strftime() has Message-ID: <20170821090124.GF16422@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Brian Inglis , newlib@sourceware.org References: <20170725185206.GE14419@calimero.vinschen.de> <9c38bcee-fbb0-9a30-0c28-58629f54aa0e@SystematicSw.ab.ca> <20170726104918.GF14419@calimero.vinschen.de> <6ae417fd-e109-4549-f005-5cfa7b6fdb62@SystematicSw.ab.ca> <20170726193443.GD30367@calimero.vinschen.de> <20170731095532.GK24013@calimero.vinschen.de> <09a4309f-a47c-5056-16bf-fe81e9ad483a@SystematicSw.ab.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="48TaNjbzBVislYPb" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SW-Source: 2017/txt/msg00848.txt.bz2 --48TaNjbzBVislYPb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2949 On Aug 19 14:53, Brian Inglis wrote: > On 2017-08-18 14:00, Brian Inglis wrote: > > On 2017-07-31 03:55, Corinna Vinschen wrote: > >> On Jul 28 14:50, Brian Inglis wrote: > >>> On 2017-07-26 13:34, Corinna Vinschen wrote: > >>>> On Jul 26 11:27, Brian Inglis wrote: > >>>>> On 2017-07-26 04:49, Corinna Vinschen wrote: > >>>>>> On Jul 25 14:13, Brian Inglis wrote: > >>>>>>> On 2017-07-25 12:52, Corinna Vinschen wrote: > >>>>>>>> Well... on *third* thought, targets may redefine time_t via rede= fining > >>>>>>>> _TIME_T_. Targets not doing that will get long, so yeah, you're= right. > >>>>>>>> Maybe it is safer to use always strtoll_l and just break this do= wn to > >>>>>>>> time_t on the way. > >>>>>>> > >>>>>>> My concern has always been do all newlib RTEMS targets support lo= ng > >>>>>>> long, even if same as long, and stroll_l? > >>>>>> > >>>>>> Yes. The long long functions are not excluded like we do with long > >>>>>> double stuff. > >>>>>> > >>>>>>> Trying to build standalone or combined STC for this with changed = strptime.c > >>>>>>> ld/collect2 fails to resolve ...global_locale. > >>>>>> > >>>>>> Yeah, it's an internal function to newlib. You need to include > >>>>>> libc/locale/setlocale.h somehow to accomplish that. STC from Cygw= in > >>>>>> userspace will do. > >>>>> > >>>>> Not doing it for me: that's why I asked if there were undistributed= locale > >>>>> changes in the tree, and maybe in a dev snapshot? > >>>> > >>>> No, it's an *internal* function, it doesn't get exported. There's no > >>>> (easy) way to build strptime.c outside the newlib tree as part of the > >>>> lib. That's why I said a userspace STC is enough. Don't try to bui= ld > >>>> strptime.c as standalone. Just build it as part of newlib/Cygwin and > >>>> test it from userspace by calling it. > >>> > >>> Finally got all the prereqs installed and a clean build. > >>> My configure uses the default prefix /usr/local, which is at the head= of my > >>> personal path. > >>> Is that enough for a test build, and how do I do that, or do I have t= o replace > >>> the current release, with configure --prefix=3D/, make install into /= bin/? > >> > >> The configured paths don't matter for the Cygwin DLL itself, and your > >> patch doesn't change any headers or entry points of the lib. So just = exit > >> from Cygwin, replace the DLL in Explorer, start a shell and go ahead. > >=20 > > Test still won't run as expected after DLL replacement, nor coreutils s= trptime. > > Aren't there lib import files or maps or anything I also have to move? > > Attached slightly redacted build config and make logs. > >=20 > > Resending without attachments to see if this makes it to the list. >=20 > Doh! Cygwin has its own strptime.cc whereas it uses strftime.c from newli= b. > Guess I should also patch Cygwin strptime.cc in a similar manner. Oh, right! I forget about it *blush* Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --48TaNjbzBVislYPb Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZmqFkAAoJEPU2Bp2uRE+gRYQP/1duJcX7OLCCZPa8+NKWH1W/ 4S89oBVHNtcp93sWFOAuLoOQHOiVxifA9CQru8ebEIoHPoRfdVi0qWLW4VOh8Nia jrSjtM0KXGYCXlVT6tII0agsn+MWsK4BKSxTcOTZuDYSrrWhteuuU6e68ifNL4n9 B9tsUh6ToUQHPXevLgNDk2Y4sgeDytkJeySYUzkZ9gq0zeGrj94Io1mRaomUkpT4 mVIcNJRA+k6vCsMhde3LjnFMLZYZotJb4QvMHbh+4GNS6I0SwPj+nHin2smaI+Zu /1ZYGpDcG2OLqkUf8QCb+nTOcfGA22/gecQ5vMBlmNPfTrg6XSoAvXAWQSPrkN2C VySGQBvaO5A6nzmeGCh8SsDxtPDVlabaqE7e060fiOH/JOk05gBcf/QexTbCPykC rvs9Ds9WApae3wBAXHybfVruo4Hku3dE2GKtOY/qPFhb3XIlgV7Oc6dJ0QRtouZl ryr0Q77UGI4Shycna/GXWFfqxGZPnNSJEhaENA01x/oIbSKPDqCeLZTxpzxvGr+R /m7NfSkMOgck4xeKE2rljEn/FOpWYbqWMJ9p9LwYm+DXidpHliGisodbYvfQ1ApW 2pdnBfyiHU74d0OBk8s8YL+wy/uppqki6+Y3KQVtOrhBmd3CxcqOLqKY5ocsn8Oh eOv5nlsHPJ3XmKMvQmvU =PaZH -----END PGP SIGNATURE----- --48TaNjbzBVislYPb--