From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45412 invoked by alias); 25 Aug 2017 12:05:12 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 39721 invoked by uid 89); 25 Aug 2017 12:05:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*R:D*sourceware.org, Attached X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Aug 2017 12:05:07 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A003C81DE2 for ; Fri, 25 Aug 2017 12:05:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A003C81DE2 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vinschen@redhat.com Received: from calimero.vinschen.de (ovpn-117-112.ams2.redhat.com [10.36.117.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B8477B9D4 for ; Fri, 25 Aug 2017 12:05:06 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id B1124A8053A; Fri, 25 Aug 2017 14:05:05 +0200 (CEST) Date: Fri, 25 Aug 2017 12:06:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib/libc/time/strptime.c(strptime_l) add strptime %F %s Message-ID: <20170825120505.GA7636@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <6ae417fd-e109-4549-f005-5cfa7b6fdb62@SystematicSw.ab.ca> <20170726193443.GD30367@calimero.vinschen.de> <20170731095532.GK24013@calimero.vinschen.de> <09a4309f-a47c-5056-16bf-fe81e9ad483a@SystematicSw.ab.ca> <20170821090124.GF16422@calimero.vinschen.de> <20170824084416.GA29964@calimero.vinschen.de> <6ebefa17-14ff-9cac-c316-2d8f80ba9025@SystematicSw.ab.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline In-Reply-To: <6ebefa17-14ff-9cac-c316-2d8f80ba9025@SystematicSw.ab.ca> User-Agent: Mutt/1.8.3 (2017-05-23) X-SW-Source: 2017/txt/msg00881.txt.bz2 --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1434 On Aug 24 13:18, Brian Inglis wrote: > On 2017-08-24 02:44, Corinna Vinschen wrote: > > Hi Brian, > > On Aug 23 12:59, Brian Inglis wrote: > >> On 2017-08-21 03:01, Corinna Vinschen wrote: > >>> Oh, right! I forget about it *blush* > >> Attached patch to support %F and %s in newlib libc time strptime.c str= ptime_l(). > >> In case the issue comes up, if the user wants to support %s as in date= (1) with a > >> preceding @ flag, they just have to include that verbatim before the f= ormat as > >> in "@%s". > >> Is there any way to test this newlib function on a Cygwin platform? > >> I don't have access to a supported platform. > >> Similar patch submitted for Cygwin %s. > > Debugging residue? > > Opening brace on next line, please, indented as the closing brace. > > Other than the above, looks good. >=20 > Sorry about that - totally missed it - both fixed in attached patch. >=20 > --=20 > Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada > From 3ee59712cd04a6fbaa074b83c92c17bfb5f2e7f1 Mon Sep 17 00:00:00 2001 > From: Brian Inglis > Date: Thu, 24 Aug 2017 13:12:17 -0600 > Subject: [PATCH] newlib/libc/time/strptime.c(strptime_l) add %F %s suppor= t for > strptime >=20 > --- > newlib/libc/time/strptime.c | 34 ++++++++++++++++++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) Pushed. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --OgqxwSJOaUobr8KG Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZoBJxAAoJEPU2Bp2uRE+gevoQAIsiBv+kN8CvQ4aowR201b/I fhM+MLjqKxQjleni3ZuxZoxytTSSJ0aRnWlQItw7mnFZ4NmxhYCO5NRefjT0DBnP P3RAQgshrH2exe1u3dCn7zqJouo0xsfVu4qGo4HmaC4uTWi3YbRHWCzeQEDSo+PO oQ/PEzaR0MZB8OiDR7wPRXAitrnYj6GRm02a1WWeojfBO2YgYwWFf/0W8mISFEN5 WU4sb1CDHLI54yFp/2tMwAJO/xu/chXGmniV18Il40QmzJirwJeGmiEoWgPH6ptA 38a96OT7f9UTyf32TDMIbe55M2WNIOR5hrIgE3fagDvqODgF/0MCgKyw+mgUT09S JEh37+uZrZlzickX7o+CdBaKRnTrldz6dcHz0QscgVJDK9Vfl4kwstXXACC5jRMV DlwEWHBD/7Izssi5EeKf48+NIQ6RuYD4JG9bnfYrUXGTOHV7PSYXPw7IkrnhRZ3G UuZAn42Eu/R3akKKEWyXg7vERlCNksLRtmGkDf5fOp8YsY1gMKwd1tqmkkLfZrHU NYEOXnExdG8H+V3TKfXlEvlAZAkMk4qJTL/w5VSamXJdAmd8Pzm3EXk1iS82mL8Z Tt0tCn70W4esI0YWGY5pleP5fFXkzfSkPwLLPqZRILNMYdc+eQQSf3GqaTZrm9Rn aU/gfen1iQUR/nRXIuAN =EGy7 -----END PGP SIGNATURE----- --OgqxwSJOaUobr8KG--