From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46457 invoked by alias); 28 Aug 2017 15:32:48 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 45750 invoked by uid 89); 28 Aug 2017 15:32:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=holidays, SSH, sk:vinsche, U*vinschen X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Aug 2017 15:32:37 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 44813C04B303; Mon, 28 Aug 2017 15:32:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 44813C04B303 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vinschen@redhat.com Received: from calimero.vinschen.de (ovpn-117-112.ams2.redhat.com [10.36.117.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F58B7FA44; Mon, 28 Aug 2017 15:32:36 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C2CCEA804AF; Mon, 28 Aug 2017 17:32:34 +0200 (CEST) Date: Mon, 28 Aug 2017 15:43:00 -0000 From: Corinna Vinschen To: Sebastian Huber Cc: newlib@sourceware.org Subject: Re: [PATCH v3 1/2] Import strnstr.c from FreeBSD. Message-ID: <20170828153234.GA25897@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Sebastian Huber , newlib@sourceware.org References: <1503646539-20199-1-git-send-email-1473996754@qq.com> <20170825160248.GE7636@calimero.vinschen.de> <457062177.160690.1503683796167.JavaMail.zimbra@embedded-brains.de> <20170828084021.GC18275@calimero.vinschen.de> <1311316118.2136.1503931403153.JavaMail.zimbra@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/" Content-Disposition: inline In-Reply-To: <1311316118.2136.1503931403153.JavaMail.zimbra@embedded-brains.de> User-Agent: Mutt/1.8.3 (2017-05-23) X-SW-Source: 2017/txt/msg00907.txt.bz2 --pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1356 On Aug 28 16:43, Sebastian Huber wrote: >=20 > ----- Corinna Vinschen schrieb: > > On Aug 25 19:56, Sebastian Huber wrote: > > > This caused a conflict with the iconv support. See attached patch. > >=20 > > > From 754f598a0a0dbde072a5baa3d4c3374333326c76 Mon Sep 17 00:00:00 2001 > > > From: Sebastian Huber > > > Date: Fri, 25 Aug 2017 19:48:42 +0200 > > > Subject: [PATCH] Fix compile error due to new strnstr() > > >=20 > > > Remove local strnstr() implementation to fix compile error: > > >=20 > > > newlib/libc/iconv/lib/aliasesi.c:53:8: error: conflicting types for '= strnstr' > > > _DEFUN(strnstr, (haystack, needle, length), > > > ^ > > > In file included from newlib/libc/iconv/lib/aliasesi.c:29:0: > > > newlib/libc/include/string.h:125:10: > > > note: previous declaration of 'strnstr' was here > > > char *strnstr(const char *, const char *, size_t) __pure; > > > ^~~~~~~ > > >=20 > > > Signed-off-by: Sebastian Huber > > > --- > > > newlib/libc/iconv/lib/aliasesi.c | 43 ------------------------------= ---------- > >=20 > > Thanks for catching, please push. >=20 > I am on holidays this week and don't have access to my SSH key. No worries. Pushed. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZpDeSAAoJEPU2Bp2uRE+gUCQP/2z21HZysFVxcwBkIShjaT1k fYcJ5jn1KAtYYANuPUppqfyf/itlEClSUAkPHSPogJEVWABzBuWuEVVe9l6abcM0 aS9Rj+cddaoSEi3PS8C7r5wt/+8sqIuKgqD1A3nLlZYekoFnr9LJdIyJS1xnwh4v snMLgr8Q87hp4NRzsyLO9j1FaTZpa25yj+jKYR0Vwb1C1K/jIIJ7aj7Zq479gx28 TFqOiMzDisIbtTakaJDTKkl9GQ5HswNfxff7D844/UbT2y2ZRDKztYTaW+jISEoT RPsFdNyY4hkkJBf2mGV+giwccOADAUHy9YdcEEIoJ4FWkUi7raOU4qAlyMiNYHNR jxmWKadciE6e/OjLLaAiA8237S8a4GTADo0kBj1xdnjE9vRPkkmIxJWJqUOfIhaq j1mFdsjmawL0zlDb8UtNdoB4VxzWcPhij0VkkVf3ori9KfAQZyjCIVEuOROpXv3b eud+qM+XQ/zbeAY4Wzsk6vbSIPlyJ1ELhza7eAEts0ATxhiJLhnm/b1aBfhv4vZj xKZMXLTZxr/d5ztSS/es9KXM3jYiuKBITm2tKW8ujfXcGNAQGHGLTee0koGHUjj4 94WFEWS84MU05joYf4BV1Bwqmc/fKdneHfCHIKCtjMRaq1Y6wIdXYSxhPmLzKHvy pn9H9o8orLym6y8AT/rn =riel -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--