From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] Modify strnstr.c.
Date: Mon, 28 Aug 2017 16:09:00 -0000 [thread overview]
Message-ID: <20170828154340.GB25897@calimero.vinschen.de> (raw)
In-Reply-To: <32b53e5f-fc9a-0aa4-0a10-f8393e73bb45@qq.com>
[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]
On Aug 28 23:14, Sichen Zhao wrote:
> > On 08/28/2017 03:45 AM, Corinna Vinschen wrote:
> > > On Aug 26 21:28, Sichen Zhao wrote:
> > > > ---
> > > > newlib/libc/string/strnstr.c | 24 ++++++++----------------
> > > > 1 file changed, 8 insertions(+), 16 deletions(-)
> > > >
> > > Input needed:
> > >
> > > Given this is a complete reimplementation not based on FreeBSD code at
> > > all, and given the code has been contributed by Eric, shouldn't we
> > > remove the entire copyright header and move this under newlib default
> > > licensing?
> > Seems reasonable to me (we aren't really copying the FreeBSD
> > implementation, just the interface). Default newlib licensing is fine;
> > it's also okay if you list yourself as author instead of me (I didn't
> > test my code, only suggested it), although if you want to put authorship
> > on my shoulders that's also okay.
> >
> Ok, the license of newlib. i copy it from other c file in newlib, like:
> /* Copyright 2017, Red Hat Inc. */
> Is that ok?
Just remove the FreeBSD copyright and don't add another one. Files
without copyright default to newlib copyright anyway.
What would be pretty nifty, though: Can you add some man page entry,
along the lines of, say, libc/string/memmem.c? This also requires a
tiny patch to libc/string/strings.tex. This would not be a requirement
for what we're discussing here, just an idea for a followup patch.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-08-28 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 8:38 Sichen Zhao
2017-08-28 8:57 ` Corinna Vinschen
2017-08-28 10:50 ` Sichen Zhao
2017-08-28 13:38 ` Sichen Zhao
2017-08-28 14:43 ` Corinna Vinschen
2017-08-28 15:15 ` Eric Blake
2017-08-28 15:32 ` Sichen Zhao
2017-08-28 16:09 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828154340.GB25897@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).